Summary: | New tab button gone missing (regression) | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Alex Hermann <gaaf> |
Component: | tabbar | Assignee: | Mariusz Glebocki <mglb> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | konsole-devel, mglb, nate, nucleo, peje66 |
Priority: | HI | Keywords: | regression, usability |
Version: | 19.08.0 | ||
Target Milestone: | --- | ||
Platform: | Debian unstable | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/konsole/616f5554b11b0420cfdd976382ff9d4f2d9f4a6a | Version Fixed In: | 19.12 |
Description
Alex Hermann
2019-08-22 10:34:49 UTC
Further investigation shows there (now?) exists a "NewTabButton" setting. It seems to have no GUI for it. The default value is false, breaking existing setups where the "new tab" button was shown before the upgrade. Manually setting "NewTabButton" to true in ~/.config/konsolerc returns the button to the tabbar. IMHO, still needs a GUI option and the value should default to the previous setting/default the user had. Yikes, it looks like this got lost in https://cgit.kde.org/konsole.git/commit/?id=a8ec9ad28adfca9cb64252b965c3da2d3f1a634b I'm not clear if removing it was on purpose or not. Is there any reason the menu can't be used here? The menu can be used. But in general I think it's poor code hygiene to leave a feature in but remove the UI to configure it; it will bit-rot because nobody uses it. IMO we should restore the configuration UI that allows the button to be shown on the tab bar, or we should remove the feature entirely. I would lean towards the former. Not intentional. Fix: https://invent.kde.org/kde/konsole/merge_requests/24 Git commit 616f5554b11b0420cfdd976382ff9d4f2d9f4a6a by Kurt Hindenburg, on behalf of Mariusz Glebocki. Committed on 25/08/2019 at 14:18. Pushed by hindenburg into branch 'master'. Restore "Show 'new tab' button" option in Konsole Settings FIXED-IN: 19.12 https://invent.kde.org/kde/konsole/merge_requests/24 M +10 -3 src/settings/TabBarSettings.ui https://invent.kde.org/kde/konsole/commit/616f5554b11b0420cfdd976382ff9d4f2d9f4a6a Git commit 616f5554b11b0420cfdd976382ff9d4f2d9f4a6a by Kurt Hindenburg, on behalf of Mariusz Glebocki. Committed on 25/08/2019 at 14:18. Pushed by scmsync into branch 'master'. Restore "Show 'new tab' button" option in Konsole Settings FIXED-IN: 19.12 https://invent.kde.org/kde/konsole/merge_requests/24 M +10 -3 src/settings/TabBarSettings.ui https://commits.kde.org/konsole/616f5554b11b0420cfdd976382ff9d4f2d9f4a6a I'd like to backport this to 19.08.1 but it will add a string. Thoughts? In principle it seems reasonable to me. Might want to give the translators a heads-up about it. Then again, if it re-adds the old string without changing anything, then there actually aren't any new strings so there's no problem. not sure how Konsole-devel ml isn't on this Git commit f780383096c1bc2b4ffe684a2a67013781dc2027 by Kurt Hindenburg. Committed on 25/08/2019 at 16:06. Pushed by hindenburg into branch 'Applications/19.08'. Restore "Show 'new tab' button" option in Konsole Settings This was inadvertedly removed in 19.08; re-add it even though it might add a new string. FIXED-IN: 19.08.1 CCMAIL: kde-i18n-doc@kde.org GUI: https://invent.kde.org/kde/konsole/merge_requests/24 M +11 -4 src/settings/TabBarSettings.ui https://invent.kde.org/kde/konsole/commit/f780383096c1bc2b4ffe684a2a67013781dc2027 Git commit f780383096c1bc2b4ffe684a2a67013781dc2027 by Kurt Hindenburg. Committed on 25/08/2019 at 16:06. Pushed by scmsync into branch 'Applications/19.08'. Restore "Show 'new tab' button" option in Konsole Settings This was inadvertedly removed in 19.08; re-add it even though it might add a new string. FIXED-IN: 19.08.1 CCMAIL: kde-i18n-doc@kde.org GUI: https://invent.kde.org/kde/konsole/merge_requests/24 M +11 -4 src/settings/TabBarSettings.ui https://commits.kde.org/konsole/f780383096c1bc2b4ffe684a2a67013781dc2027 Thank you all for the quick responses and fix. *** Bug 411379 has been marked as a duplicate of this bug. *** |