Summary: | Category icons should come from the icon theme, not the Plasma theme | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Miroslav Spehar <mspehar> |
Component: | Application Launcher (Kickoff) | Assignee: | David Edmundson <kde> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | laubblaeser, nate, plasma-bugs |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: |
https://bugs.kde.org/show_bug.cgi?id=373087 https://bugs.kde.org/show_bug.cgi?id=438191 |
||
Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/7d1ede498e0157ab90b364d093d4d5690d201158 | Version Fixed In: | 6.0 |
Sentry Crash Report: |
Description
Miroslav Spehar
2019-08-06 14:24:02 UTC
This is intentional right now, but maybe it shouldn't be. Overall I don't really like the fact that Plasma themes have icons in them and I think the icon theme should control everything. Anything else is quite unpredictable and can cause difficulty achieving unified icon styling throughout the system. Absolutely agree with the points made here. Inconsistency in icon theming is a very annoying thing to deal with. >and I think the icon theme should control everything
That just replaces things with a dozen other bug reports about everyone's system tray looking like a rainbow, so it's not quite so trivial.
Kickoff category icons are changable without big refactors. It's just a case of adding
```
usesPlasmaTheme: false
```
if we want it
This comes from Purpose which is in Frameworks, and it was fixed recently! Oops, wrong bug. Actually, we have a somewhat longstanding request to do just that for the System Tray too: Bug 373087. Maybe it's something we should *sigh* just make configurable. Personally I don't see the need though. I don't really understand the use case of wanting to use colorful small action items in your apps, but have a totally different set of icons used in Plasma. This has been fixed for Plasma 6 by using Kirigami.Icon to draw all the icons in Kickoff, which always pulls from the Icon theme, not the Plasma theme. |