| Summary: | Replace warning message with inline message when changing settings | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Patrick Silva <bugseforuns> |
| Component: | kcm_formats | Assignee: | Sebastian Kügler <sebas> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | Keywords: | usability |
| Version: | 5.16.4 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/32a565bae7e2f7243d2715df56b8617dc8dd3612 | Version Fixed In: | 5.24 |
| Sentry Crash Report: | |||
| Attachments: | Formats kcm showing warning message | ||
Git commit 25485ac8d35ec25c1cf1475516016d6f8b93a9f2 by Nate Graham, on behalf of Han Young. Committed on 05/10/2021 at 17:20. Pushed by ngraham into branch 'master'. port formats to qml Related: bug 279658, bug 338599, bug 362865, bug 389529, bug 422467, bug 426313 FIXED-IN: 5.24 M +16 -7 kcms/formats/CMakeLists.txt D +0 -113 kcms/formats/formats.desktop M +46 -326 kcms/formats/kcmformats.cpp M +15 -33 kcms/formats/kcmformats.h D +0 -385 kcms/formats/kcmformatswidget.ui https://invent.kde.org/plasma/plasma-workspace/commit/25485ac8d35ec25c1cf1475516016d6f8b93a9f2 Git commit 32a565bae7e2f7243d2715df56b8617dc8dd3612 by Ben Cooksley, on behalf of Han Young. Committed on 06/10/2021 at 07:41. Pushed by bcooksley into branch 'master'. kcms/formats: port to QML Related: bug 279658, bug 338599, bug 362865, bug 389529, bug 422467, bug 426313 FIXED-IN: 5.24 M +16 -7 kcms/formats/CMakeLists.txt A +66 -0 kcms/formats/exampleutility.cpp [License: GPL(v2.0+)] D +0 -113 kcms/formats/formats.desktop A +61 -0 kcms/formats/formatssettings.kcfg A +6 -0 kcms/formats/formatssettings.kcfgc M +46 -326 kcms/formats/kcmformats.cpp M +15 -33 kcms/formats/kcmformats.h D +0 -385 kcms/formats/kcmformatswidget.ui A +176 -0 kcms/formats/localelistmodel.cpp [License: GPL (v2+)] A +58 -0 kcms/formats/localelistmodel.h [License: GPL (v2+)] A +140 -0 kcms/formats/optionsmodel.cpp [License: GPL(v2.0+)] A +32 -0 kcms/formats/optionsmodel.h [License: GPL(v2.0+)] A +126 -0 kcms/formats/package/contents/ui/main.qml [License: LGPL(v3.0+)] A +23 -0 kcms/formats/package/metadata.desktop https://invent.kde.org/plasma/plasma-workspace/commit/32a565bae7e2f7243d2715df56b8617dc8dd3612 |
Created attachment 121943 [details] Formats kcm showing warning message SUMMARY As we can see in the attached screenshot, currently Formats kcm shows a warning message when applying changes. Replacing it with inline message would bring consistency with other KCMs that also show a message after we apply changes, like Fonts and Language KCMs. STEPS TO REPRODUCE 1. open system settings > Regional settings > Formats 2. change any setting 3. click "Apply" button OBSERVED RESULT warning message EXPECTED RESULT inline message SOFTWARE/OS VERSIONS Linux/KDE Plasma: Arch Linux (available in About System) KDE Plasma Version: 5.16.4 KDE Frameworks Version: 5.60 Qt Version: 5.13