Bug 410532

Summary:	Shift and Alt modifiers don't work using the outline selection tool.
Product:	[Applications] krita	Reporter:	Maurice Campobasso <cybermotroncom>
Component:	Tools/Selection	Assignee:	Dmitry Kazakov <dimula73>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla, josiewing44, katearcher89, loudsquid, necromancer007
Priority:	NOR	Keywords:	regression, release_blocker
Version:	4.2.5
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/kde/krita/commit/1926358bb83f710c0084b9d5021ec08c73614583	Version Fixed In:
Sentry Crash Report:

Description Maurice Campobasso 2019-08-03 08:45:59 UTC

SUMMARY
The Shift and Alt modifiers no longer work using the Outline Selection Tool. This happens whether in vector or bitmap mode and also with or without anti-aliasing. The modifiers work fine for all the other selection tools.

STEPS TO REPRODUCE
1. Make a selection using any tool.
2. Attempt to Add or Subtract from the selection using the Outline Selection Tool and Shift or Alt keys.

OBSERVED RESULT
It makes a whole new selection.

EXPECTED RESULT
It should add to or subtract from the selection.

SOFTWARE/OS VERSIONS
Windows: 10

Comment 1 Halla Rempt 2019-08-03 08:53:00 UTC

I thought deevad had already reported this, but I cannot find the report. I can confirm the issue though.

Comment 2 Halla Rempt 2019-08-03 12:56:12 UTC

The commit that introduced this problem seems to be:

commit 09ae9a67adce4deca6e64581b23c0d7637d86cb5
Author: Dmitry Kazakov <dimula73@gmail.com>
Date:   Tue Jul 30 19:14:54 2019 +0300
Make sure that the tool action is deactivated/finished exactly for the canvas it was started
When switching canvases (creating new ones), it might happen that the
tool proxy will be switched right in the middle of the stroke. In
such a case we should deactivate/finish the action of the *old* canvas,
not the new one.
BUG:398968

Comment 3 Halla Rempt 2019-08-10 08:45:04 UTC

*** Bug 410747 has been marked as a duplicate of this bug. ***

Comment 4 Halla Rempt 2019-08-10 10:26:55 UTC

*** Bug 410665 has been marked as a duplicate of this bug. ***

Comment 5 Halla Rempt 2019-08-14 08:30:38 UTC

*** Bug 410887 has been marked as a duplicate of this bug. ***

Comment 6 Dmitry Kazakov 2019-08-14 10:31:14 UTC

Git commit bd06296f66a4620099c59bdee5a85d07fbb61d39 by Dmitry Kazakov.
Committed on 14/08/2019 at 10:31.
Pushed by dkazakov into branch 'master'.

Fix Shift and Alt modifiers in OUtline Selection Tool

We should pass the keys to the tool, even when it is not active
to make sure its keyPress/keyRelease methods work fine. To make
it works we need to initialize the environment correctly in
KisToolInvocationAction::processUnhandledEvent;
BACKPORT:krita/4.2

M  +5    -0    libs/ui/input/kis_tool_invocation_action.cpp
M  +2    -0    plugins/tools/selectiontools/kis_tool_select_outline.cc

https://invent.kde.org/kde/krita/commit/bd06296f66a4620099c59bdee5a85d07fbb61d39

Comment 7 Halla Rempt 2019-08-14 16:21:46 UTC

*** Bug 410900 has been marked as a duplicate of this bug. ***

Comment 8 Dmitry Kazakov 2019-08-14 16:41:49 UTC

Git commit 1926358bb83f710c0084b9d5021ec08c73614583 by Dmitry Kazakov.
Committed on 14/08/2019 at 16:21.
Pushed by dkazakov into branch 'krita/4.2'.

Fix Shift and Alt modifiers in OUtline Selection Tool

We should pass the keys to the tool, even when it is not active
to make sure its keyPress/keyRelease methods work fine. To make
it works we need to initialize the environment correctly in
KisToolInvocationAction::processUnhandledEvent;
BACKPORT:krita/4.2

M  +5    -0    libs/ui/input/kis_tool_invocation_action.cpp
M  +2    -0    plugins/tools/selectiontools/kis_tool_select_outline.cc

https://invent.kde.org/kde/krita/commit/1926358bb83f710c0084b9d5021ec08c73614583