| Summary: | Adjust the size of kickoff settings window to unhide the tip on bottom | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
| Component: | Application Launcher (Kickoff) widget | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, plasma-bugs-null, postix |
| Priority: | NOR | ||
| Version First Reported In: | 5.16.90 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/184f2a8274dc38786a0ca3cb22f49e1a2d688aae | Version Fixed/Implemented In: | 5.17.0 |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
Submitted a patch: https://phabricator.kde.org/D23158 Git commit 184f2a8274dc38786a0ca3cb22f49e1a2d688aae by Nate Graham.
Committed on 26/09/2019 at 20:18.
Pushed by ngraham into branch 'Plasma/5.17'.
[applets/kickoff] Improve appearance of draggable button grid in settings window
Summary:
The button grid was not centered, the content inside the buttons was not centered, the
vertical spacing was too high on top and too low on bottom, and the explanatory text
got cut off.
This patch solves all those problems.
Big thanks to @davidedmundson for his help getting this merge-ready.
FIXED-IN: 5.17.0
Test Plan:
Before: {F7247447, size=full}
After: {F7247446, size=full}
Reviewers: #vdg, #plasma, davidedmundson, GB_2, hein
Reviewed By: #vdg, #plasma, davidedmundson, GB_2
Subscribers: hein, GB_2, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23158
M +13 -10 applets/kickoff/package/contents/ui/ConfigButtons.qml
M +5 -6 applets/kickoff/package/contents/ui/ConfigGeneral.qml
M +20 -19 applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml
https://commits.kde.org/plasma-desktop/184f2a8274dc38786a0ca3cb22f49e1a2d688aae
|
Created attachment 121612 [details] screenshot SUMMARY As we can see in the attached screenshot, currently "Drag tabs between the boxes..." on bottom is hidden when you open kickoff settings. STEPS TO REPRODUCE 1. open kickoff settings 2. 3. EXPECTED RESULT The tip on bottom is always visible when you open kickoff settings. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.16.3 KDE Frameworks Version: 5.60.0 Qt Version: 5.13.0