Summary: | KIO FTP: kioclient hangs while copying file over existing file [copy() did not call finished() or error()] | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Yaroslav Sidlovsky <zawertun> |
Component: | FTP | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | Dr, jm.dev, kdelibs-bugs, KVAnton.WEB, nate, nortexoid, sh200105, simonebondi456 |
Priority: | NOR | ||
Version: | 5.60.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio/ccae728a5494658d865705628bb6e89ead4dd54e | Version Fixed In: | 5.62 |
Description
Yaroslav Sidlovsky
2019-07-18 13:12:07 UTC
Proposed fix: https://phabricator.kde.org/D22528 I also have this problem in the Dolphin. OS: KDE neon 5.16 DE: KDE 5.60.0 / Plasma 5.16.3 Qt: 5.12.3 Kernel: x86_64 Linux 5.0.0-050000-generic Confirm this bug Bug still present in plasma 5.16.4. Duplicate of: https://bugs.kde.org/show_bug.cgi?id=410357. *** Bug 410357 has been marked as a duplicate of this bug. *** Can confirm. The dialogs either do not show or show after a long delay, but the FTP connections stay alive and have to be manually closed. Git commit ccae728a5494658d865705628bb6e89ead4dd54e by Harald Sitter, on behalf of Yaroslav Sidlovsky. Committed on 22/08/2019 at 13:09. Pushed by sitter into branch 'master'. KIO FTP: Fix file copy hanging when copying to existing file Summary: BUG: 409954 Test Plan: Before patch: 1. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png 2. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png Kioclient will hang with debug message: `kf5.kio.core: copy() did not call finished() or error()! Please fix the "kio_ftp" KIO slave` After patch: 1. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png 2. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png All is OK, kioclient5 will exit with error status and say that file already exists. Reviewers: sitter, dfaure, cfeck Reviewed By: sitter Subscribers: ngraham, rikmills, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D22528 M +4 -6 src/ioslaves/ftp/ftp.cpp https://commits.kde.org/kio/ccae728a5494658d865705628bb6e89ead4dd54e *** Bug 411819 has been marked as a duplicate of this bug. *** |