| Summary: | collapse-all icons don’t respect color schemes | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Laura David Hurka <laura.stern> |
| Component: | Icons | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kainz.a, laura.stern, nate |
| Priority: | NOR | ||
| Version: | 5.16.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Unspecified | ||
| Latest Commit: | https://commits.kde.org/breeze-icons/8ec6b1ba567029067e458525048477a489b042c3 | Version Fixed In: | 5.61 |
| Sentry Crash Report: | |||
|
Description
Laura David Hurka
2019-07-06 08:30:17 UTC
Git commit 8ec6b1ba567029067e458525048477a489b042c3 by Nate Graham, on behalf of Natsumi Higa.
Committed on 07/07/2019 at 12:26.
Pushed by ngraham into branch 'master'.
Add id="current-color-scheme" to collapse-all icons
Summary:
`collapse-all` icons have no `id="current-color-scheme"` attribute in the `<style>` element, so they do not respect the foreground color and these icons are hardly visible in dark color themes.
Special thanks: David Hurka, who reported the bug and suggested the change
Usage in Okular, Before:
{F6848602}
After:
{F6980718}
Reviewers: #vdg, davidhurka, ndavis
Reviewed By: #vdg, davidhurka, ndavis
Subscribers: ndavis, davidhurka, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22297
M +9 -2 icons-dark/actions/16/collapse-all.svg
M +9 -2 icons-dark/actions/22/collapse-all.svg
M +9 -2 icons-dark/actions/24/collapse-all.svg
M +9 -2 icons-dark/actions/32/collapse-all.svg
M +9 -2 icons/actions/16/collapse-all.svg
M +9 -2 icons/actions/22/collapse-all.svg
M +9 -2 icons/actions/24/collapse-all.svg
M +9 -2 icons/actions/32/collapse-all.svg
https://commits.kde.org/breeze-icons/8ec6b1ba567029067e458525048477a489b042c3
|