| Summary: | Disk quota icon is semantically incorrect | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Nicolas Fella <nicolas.fella> |
| Component: | Icons | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bfeber, bugseforuns, flopss, kainz.a, nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/breeze-icons/commit/8936f14e15cff18171e73b8ffa69cce1b339db76 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Incorrect icon | ||
|
Description
Nicolas Fella
2019-06-22 07:52:26 UTC
Shows a folder but should show a disk, I imagine. :) Created attachment 123265 [details]
Incorrect icon
I have, the same problem with other icons (Papirus).
Disk Quoata doesn't look on icons theme.
(In reply to Serge Pavlyuk from comment #2) > Created attachment 123265 [details] > Incorrect icon > > I have, the same problem with other icons (Papirus). > Disk Quoata doesn't look on icons theme. That's most likely the icon theme's fault. (In reply to Björn Feber from comment #3) > (In reply to Serge Pavlyuk from comment #2) > > Created attachment 123265 [details] > > Incorrect icon > > > > I have, the same problem with other icons (Papirus). > > Disk Quoata doesn't look on icons theme. > > That's most likely the icon theme's fault. Defently not cause it reproduces on every icon theme (In reply to Serge Pavlyuk from comment #4) > (In reply to Björn Feber from comment #3) > > (In reply to Serge Pavlyuk from comment #2) > > > Created attachment 123265 [details] > > > Incorrect icon > > > > > > I have, the same problem with other icons (Papirus). > > > Disk Quoata doesn't look on icons theme. > > > > That's most likely the icon theme's fault. > > Defently not cause it reproduces on every icon theme Unless icon name is renamed and all themes are outdated for this change. The icon in question does not come from the icon theme but from the plasma theme. Changing the icon theme does nothing here (In reply to Nicolas Fella from comment #6) > The icon in question does not come from the icon theme but from the plasma > theme. Changing the icon theme does nothing here Thank you. So in this case i need the same patch that would be done for Breeze theme do for any other theme that i know, correct? Is it possible to track down the bug fix to the patch that will fix it, so i could create a pull request to other themes? Thank you once again. Well, the "bug" is that the icon should look different. It's a matter of changing https://cgit.kde.org/plasma-framework.git/tree/src/desktoptheme/breeze/icons/disk.svg A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/170 Git commit 8936f14e15cff18171e73b8ffa69cce1b339db76 by Andreas Kainz. Committed on 14/11/2021 at 21:31. Pushed by andreask into branch 'master'. M +20 -13 icons-dark/status/22/disk-quota-critical.svg M +17 -9 icons-dark/status/22/disk-quota-high.svg M +12 -6 icons-dark/status/22/disk-quota-low.svg M +14 -8 icons-dark/status/22/disk-quota.svg M +20 -13 icons/status/22/disk-quota-critical.svg M +17 -9 icons/status/22/disk-quota-high.svg M +12 -6 icons/status/22/disk-quota-low.svg M +14 -8 icons/status/22/disk-quota.svg https://invent.kde.org/frameworks/breeze-icons/commit/8936f14e15cff18171e73b8ffa69cce1b339db76 |
