Bug 407790

Summary:	Misleading cmake message if building without vlc
Product:	[Applications] Elisa	Reporter:	Antonio Rojas <arojas>
Component:	general	Assignee:	Matthieu Gallien <matthieu_gallien>
Status:	RESOLVED FIXED
Severity:	normal	CC:	groot
Priority:	NOR
Version First Reported In:	0.4.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/elisa/e23fdcb93a3c768ecb514ffa030dc2e7fcec8e43	Version Fixed/Implemented In:
Sentry Crash Report:

Description Antonio Rojas 2019-05-21 08:57:52 UTC

SUMMARY
If you build elisa 0.4 without vlc you get a cmake message:

 * LIBVLC, libvlc allows to play music in Elisa, <https://www.videolan.org/vlc/libvlc.html>

This wrongly hints that elisa will not play music without it. I just found out by a user bug report that qtmultimedia is still supported.

Comment 1 Matthieu Gallien 2019-05-21 09:24:09 UTC

Thanks for the report. I will clarify the message.

Comment 2 Matthieu Gallien 2019-05-21 15:25:16 UTC

https://phabricator.kde.org/D21318 is open for review

Comment 3 Matthieu Gallien 2019-05-22 15:26:46 UTC

Git commit e23fdcb93a3c768ecb514ffa030dc2e7fcec8e43 by Matthieu Gallien.
Committed on 22/05/2019 at 15:26.
Pushed by mgallien into branch '0.4'.

improve wording of description of libvlc dependency

Summary:
Makes the description printed by cmake easier to understand

Reviewers: #elisa, arojas, ngraham

Reviewed By: #elisa, arojas, ngraham

Subscribers: ngraham

Differential Revision: https://phabricator.kde.org/D21318

M  +1    -1    CMakeLists.txt

https://commits.kde.org/elisa/e23fdcb93a3c768ecb514ffa030dc2e7fcec8e43

Comment 4 Antonio Rojas 2019-05-23 11:48:33 UTC

*** Bug 407864 has been marked as a duplicate of this bug. ***