Summary: | Delete applet config window and move its single option elsewhere (into the applet's context menu, maybe?) | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Kishore Gopalakrishnan <kishore96> |
Component: | Battery Monitor | Assignee: | Kai Uwe Broulik <kde> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | bugseforuns, nate, plasma-bugs |
Priority: | NOR | ||
Version: | 5.15.5 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/9eafbd28bd3d1c5fb5d6b5d1dae9f38c7ec278ef | Version Fixed In: | 5.22 |
Description
Kishore Gopalakrishnan
2019-05-15 14:49:56 UTC
The applet's config window only has a single checkbox. I think a whole settings window is total overkill and the better solution is to move this somewhere else. Maybe it could even be a checkable menu item in the right-click menu. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/811 Git commit 9eafbd28bd3d1c5fb5d6b5d1dae9f38c7ec278ef by Nate Graham. Committed on 05/05/2021 at 15:42. Pushed by ngraham into branch 'master'. [applets/batterymonitor] Overhaul configuration and actions Right now the applet puts the entries to open the KCM and Energy Info page in a hamburger menu, while the Configure button opens the applet's own settings window which has only one item in it. This emphasizes the less important thing, while de-emphasizing the more important thing. We can solve this by making the applet's configure button open the KCM instead of the applet configuration window. This makes the configuration window inaccessible, so we delete it and move its one setting into the hamburger menu along with "Show Energy Information". This is okay as these two are lesser-used settings. Overall this should make the actions easier to access and use, and more relevant to the user. FIXED-IN: 5.22 D +0 -30 applets/batterymonitor/package/contents/config/config.qml D +0 -41 applets/batterymonitor/package/contents/ui/ConfigGeneral.qml M +16 -4 applets/batterymonitor/package/contents/ui/batterymonitor.qml https://invent.kde.org/plasma/plasma-workspace/commit/9eafbd28bd3d1c5fb5d6b5d1dae9f38c7ec278ef |