| Summary: | "Allow guests" checkbox is enabled despite its state can not be changed | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kdenetwork-filesharing | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kdenetwork-filesharing/29c9fc1d09b92649c48b966b1df4ae3277e56634 | Version Fixed In: | 19.04.2 |
| Attachments: | screen recording | ||
I think the root cause here is that the Samba share you're trying to create doesn't actually get created successfully (Bug 381301). Can you confirm? No. I can create samba shares. The same behavior shown in the screen recording occurs on Arch Linux. Operating System: Arch Linux KDE Plasma Version: 5.15.90 KDE Frameworks Version: 5.58.0 Qt Version: 5.13.0 beta3 Oh, this is just a UI bug then. That checkbox shouldn't even be enabled if the folder isn't being shared. Here's a patch: https://phabricator.kde.org/D21253 Git commit 29c9fc1d09b92649c48b966b1df4ae3277e56634 by Nate Graham.
Committed on 17/05/2019 at 20:29.
Pushed by ngraham into branch 'Applications/19.04'.
Enable and disable UI controls properly based on sharing status
Summary:
When a folder isn't shared, all of the UI controls that depend on it being shared
should be disabled.
FIXED-IN: 19.04.1
Test Plan: {F6828673, size=full, loop=true, autoplay=true}
Reviewers: #vdg, filipf
Reviewed By: #vdg, filipf
Differential Revision: https://phabricator.kde.org/D21253
M +4 -1 samba/filepropertiesplugin/sambausershareplugin.cpp
M +4 -1 samba/filepropertiesplugin/sambausershareplugin.ui
https://commits.kde.org/kdenetwork-filesharing/29c9fc1d09b92649c48b966b1df4ae3277e56634
|
Created attachment 120045 [details] screen recording SUMMARY Watch the screen recording. "Allow guests" checkbox is enabled but it's impossible to check it. EXPECTED RESULT Keep "Allow guests" option greyed out until "Share with Samba (ms windows)" is checked. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.15.80 KDE Frameworks Version: 5.58.0 Qt Version: 5.12.0