Summary: | new notifications: "Open" and hamburger buttons should have the same height | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
Component: | Notifications | Assignee: | Kai Uwe Broulik <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, kdelibs-bugs, nate, plasma-bugs |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-workspace/19e8b39b5b46d3d09818493c916df533ce879459 | Version Fixed In: | 5.16.0 |
Attachments: |
screenshot
Smaller icon only button |
Description
Patrick Silva
2019-05-12 14:04:29 UTC
Created attachment 120010 [details]
screenshot
Probably an issue with PlasmaComponents but maybe we can do a local workaround like we did for the login and lock screens: https://cgit.kde.org/plasma-workspace.git/tree/lookandfeel/contents/lockscreen/MainBlock.qml#n97 I would prefer this to be fixed in PlasmaComponents. Especially since that workaround subtracts half of units.smallSpacing which is quite a magic number. I just updated plasma-framework: tests/components/button.qml I get buttons being the same height. There's something else going on in this patch that I don't understand. Try with a button that has just an icon but no text I did, it looks fine. Created attachment 120035 [details]
Smaller icon only button
Look how that button with just an icon is slightly smaller
I see the same height discrepancy, BTW. So the code is: max(fontSize * 1.6, textSize + marginTop + marginBottom) fontSize will apply for icon only, but textSize will be 0 In theory fontSize and textSize should be the same. Clearly you guys have margins that are bigger than your font * 0.6 It seems this doesn't exist with PC3, so maybe it's not worth fixing the root issue. Git commit 19e8b39b5b46d3d09818493c916df533ce879459 by Kai Uwe Broulik. Committed on 24/05/2019 at 13:47. Pushed by broulik into branch 'Plasma/5.16'. [Notifications] Ensure "Open" and "More Options" button have the same height Differential Revision: https://phabricator.kde.org/D21181 M +3 -0 applets/notifications/package/contents/ui/JobItem.qml https://commits.kde.org/plasma-workspace/19e8b39b5b46d3d09818493c916df533ce879459 |