| Summary: | Discover lists Snap packages without icon in search results | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Patrick Silva <bugseforuns> |
| Component: | discover | Assignee: | Dan Leinir Turthra Jensen <leinir> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol, ianp, nate, null |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kirigami/19d09d1ef958b68b8de56965b97d647cfe4ea7b6 | Version Fixed In: | 5.62 |
| Sentry Crash Report: | |||
| Attachments: |
screenshot
screen recording on neon unstable |
||
LOL I see the opposite problem: the list entry has an icon, but the app page doesn't! I've observed the icon appearing after a DELAY or a refresh. EG on the GIMP Snap. Search gimp. Git commit 19d09d1ef958b68b8de56965b97d647cfe4ea7b6 by Aleix Pol. Committed on 06/08/2019 at 13:42. Pushed by apol into branch 'master'. Kirigami.Icon: Fix loading bigger images when source is a URL Summary: Port to using the QImage::load() that takes a QIODevice and only do it when the execution is finished, instead of upon readyRead(). This makes sure that we are only processing the icon when is fully downloaded. Related: bug 400312 Test Plan: Reproduced the bug and fixed it Reviewers: #frameworks, #kirigami, mart Reviewed By: #kirigami, mart Subscribers: broulik, plasma-devel Tags: #kirigami Differential Revision: https://phabricator.kde.org/D22952 M +36 -42 src/icon.cpp M +2 -2 src/icon.h https://commits.kde.org/kirigami/19d09d1ef958b68b8de56965b97d647cfe4ea7b6 This bug is not completelly fixed. Sometimes the app icon only appears after I hover over the snap package listed in the search resuls and then move the cursor outside it. I recorded a video on Neon unstable edition showing this behavior. Created attachment 123152 [details]
screen recording on neon unstable
I did reproduce it. *** Bug 404372 has been marked as a duplicate of this bug. *** cannot reproduce on neon unstable. |
Created attachment 119970 [details] screenshot STEPS TO REPRODUCE 1. search for "vscode" 2. 3. OBSERVED RESULT Discover lists Snap packages without icon. The app icon is present in its description page. See the attached screenshot. EXPECTED RESULT Snap packages have icon in search result. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.15.80 KDE Frameworks Version: 5.58.0 Qt Version: 5.12.0