| Summary: | Song duration display in the Playlist regressed recently | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/elisa/c4c06554076bd4839a2f9ee925731bc5459bc55c | Version Fixed In: | |
| Attachments: | All song durations elided | ||
I am going to fix all usage of TextMetrics and also add rounding when a font.pointSize is multiplied. Let's see if it's enough. I am working on this. Patch to try to fix that issue: https://phabricator.kde.org/D21198 Git commit c4c06554076bd4839a2f9ee925731bc5459bc55c by Matthieu Gallien. Committed on 14/05/2019 at 05:25. Pushed by mgallien into branch '0.4'. compute correct sizes when using TextMetrics Summary: Use boundingRect of TextMetrics to compute the correct sizes ensure all font.pointSize are set to integer values Test Plan: Everything is looking fine Reviewers: #elisa, ngraham Reviewed By: ngraham Differential Revision: https://phabricator.kde.org/D21198 M +1 -7 src/qml/BaseTheme.qml M +3 -3 src/qml/BasicPlayListAlbumHeader.qml M +5 -9 src/qml/ContextView.qml M +3 -2 src/qml/FileBrowserDelegate.qml M +3 -1 src/qml/GridBrowserDelegate.qml M +3 -1 src/qml/GridBrowserView.qml M +0 -10 src/qml/MediaPlayListView.qml M +2 -2 src/qml/MediaPlayerControl.qml M +0 -6 src/qml/MediaTrackDelegate.qml M +2 -1 src/qml/MetaDataDelegate.qml M +2 -16 src/qml/NavigationActionBar.qml M +18 -18 src/qml/PlayListEntry.qml M +29 -23 src/qml/SimplePlayListEntry.qml M +1 -1 src/qml/TopNotificationItem.qml M +1 -1 src/qml/TrackImportNotification.qml M +1 -1 src/qml/ViewSelector.qml https://commits.kde.org/elisa/c4c06554076bd4839a2f9ee925731bc5459bc55c |
Created attachment 119915 [details] All song durations elided Elisa from git master. See attachment.