| Summary: | joystick icon looks a black ball | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Patrick Silva <bugseforuns> |
| Component: | Icons | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kainz.a, nate |
| Priority: | NOR | ||
| Version: | 5.15.4 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/breeze-icons/7ef3c35c7ed69a507f25a6cb8cd92fbb223756a7 | Version Fixed In: | 5.60 |
| Attachments: | screenshot | ||
Yeah, it kind of does. There are multiple problems here: - the Joystick KCM uses the icon `preferences-desktop-gaming` which is semantically incorrect (The KCM is about configuring the joystick input device, not gaming in general) - The preferences-desktop-gaming icon depicts the two-dimensional D-pad from a gaming controller, rather than a generic gaming-related icon like input-gaming - We have no icon that actually shows a joystick I think the solution is to: 1. Create a new icon `input-joystick` that actually looks like a joystick 2. Make a symlink called `preferences-desktop-joystick` that points to it 3. Have the joystick KCM use that icon, 4.Make `preferences-desktop-gaming` a symlink to `input-gaming`, and keep that in our back pocket for if we ever have generic gaming-related KCM. Git commit 7ef3c35c7ed69a507f25a6cb8cd92fbb223756a7 by Noah Davis.
Committed on 20/06/2019 at 10:33.
Pushed by ndavis into branch 'master'.
Change joystick settings icon to game controller
Summary:
Most of the "joysticks" that people have are game controllers, so a complete controller is better than just a D-pad.
FIXED-IN: 5.60
Test Plan:
left: old, right: new
{F6917203, size=full}
Reviewers: #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: usta, davidedmundson, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D21919
T +1 -64 icons-dark/preferences/32/preferences-desktop-gaming.svg
T +1 -64 icons/preferences/32/preferences-desktop-gaming.svg
https://commits.kde.org/breeze-icons/7ef3c35c7ed69a507f25a6cb8cd92fbb223756a7
|
Created attachment 119503 [details] screenshot SUMMARY As we can see in attached screenshot, joystick icon has no similarity with a joystick, it looks a black ball. STEPS TO REPRODUCE 1. open system settings > input devices and observe the icon of "Joystick" section 2. 3. EXPECTED RESULT joystick icon looks a... joystick SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.15.4 KDE Frameworks Version: 5.57.0 Qt Version: 5.12.2