| Summary: | Elide tab title on the left when displaying full paths | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Julius R. <c3i8zv295> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, elvis.angelaccio, nate |
| Priority: | NOR | ||
| Version: | 18.12.3 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/d863dd9ad46b3a291751bcb9d6fd3930c4ea8afb | Version Fixed In: | 19.04.2 |
| Sentry Crash Report: | |||
| Attachments: | Left aligned tab description... | ||
|
Description
Julius R.
2019-04-15 15:30:39 UTC
Sounds like instead, we could just slide left instead of eliding right. But could you attach a screenshot illustrating the problem? Created attachment 119491 [details]
Left aligned tab description...
I am unwilling to believe, no one ever stumbled across this problem? With left aligned text in tabs, there is no way to differentiate between the folders of other open tabs. :)
Ah, you're using the "Show full path in titlebar" option, which has the effect of putting it in the tabs too, since the tabs show the titlebar's title. Would an acceptable alternative be to make the tabs only show the name of their current directory when using "Show full path in titlebar", rather than the full path? Oh my... I am ashamed, the most important info is missing: That I am using the "show full path in titlebar" option. Sorry! Yeah, of course, switching to current folder works - I am using this right now. But still, when having the full path enabled, it should be text-align: right :) Just for logical and obvious reasons. Have a nice weekend. Stop. Stupid me! I am too tired. We are misleading each other. I am not talking about the location pane. I am talking about the TABS! The circled path in the tabs! Think about the following: You have four tabs open. Now you want to drag and drop on file from your current view, to one of the four tabs. I mean, literally, clicking file test.xyz, dragging to a TAB (!) and releasing it right there. How is a user supposed to know, what folder that tab is? Have a look at the screenshot, it is impossible to tell. We see the root of the tabs folders, but not the folders name of the open tabs! The problem is NOT the location bar, it is the abbreviated display of names in the tabs themselves :) Cheers Yep, I get it. Here's a patch: https://phabricator.kde.org/D20689 Whoa, that was fast. Thank you very much! Have a nice easter time. :) Git commit d863dd9ad46b3a291751bcb9d6fd3930c4ea8afb by Nate Graham.
Committed on 20/05/2019 at 13:14.
Pushed by ngraham into branch 'Applications/19.04'.
Elide tab titles left so key information at the end of the string doesn't get cut off
Summary:
Tab Titles currently elide right. Generally the more useful information is at the right
side of the string--even more so when full paths are being used.
FIXED-IN: 19.04.2
Test Plan:
- No change when tab titles don't get elided
- When tabs show the full path and titles are elided, they're now useful: {F6782447}
- When tabs don't show the full path and are elided, they're elided on the other side which seems maybe a tiny bit better, but at least no worse: {F6782448}
Reviewers: #dolphin, #vdg, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: ndavis, elvisangelaccio, kneckermcknacksack, filipf, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D20689
M +9 -0 src/dolphintabwidget.cpp
https://commits.kde.org/dolphin/d863dd9ad46b3a291751bcb9d6fd3930c4ea8afb
|