| Summary: | Sidebar text gets elided for most window sizes | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/elisa/debeff777c3c99293ff30be9872d7b8d00fa580b | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Elided sidebar text | ||
Thanks for your report. I'm working on this FWIW. Here's a patch: https://phabricator.kde.org/D20577 Git commit debeff777c3c99293ff30be9872d7b8d00fa580b by Nate Graham.
Committed on 16/04/2019 at 16:12.
Pushed by ngraham into branch 'master'.
Don't adjust the sidebar size with the window size, and reduce the text size a bit
Summary:
Currently the sidebar text is huge and the sidebar itself adjusts its width with
the window's own width. This results in sidebar items' text getting elided with
most window sizes.
This patch reduces the text size a bit and fixes the size, resolving both problems.
Test Plan: {F6774559, size=full}
Reviewers: mgallien, #elisa
Reviewed By: mgallien, #elisa
Subscribers: filipf
Differential Revision: https://phabricator.kde.org/D20577
M +1 -1 src/qml/BaseTheme.qml
M +0 -3 src/qml/ContentView.qml
M +5 -6 src/qml/ViewSelector.qml
https://commits.kde.org/elisa/debeff777c3c99293ff30be9872d7b8d00fa580b
|
Created attachment 119384 [details] Elided sidebar text Elisa from git master. Sidebar items' text gets elided for window sizes any smaller than being maximized. See attached screenshot. In English, this affects "Recently Played" and "Frequently Playing", and I imagine the problem is even worse in languages where test is generally longer. It seems like there are two problems here: 1. The sidebar dynamically resizes itself according to the window width instead of being a fixed size according to the length of the longest string 2. Sidebar items' text is really large, exacerbating problem #1.