| Summary: | Song names in playlist are elided even when there's plenty of space available | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/elisa/358086c2228945e84d0d60a1c94694ec8c3b1bbc | Version Fixed In: | |
| Attachments: | Elided song names when there'e plenty of space | ||
|
Description
Nate Graham
2019-04-12 15:56:44 UTC
Git commit 358086c2228945e84d0d60a1c94694ec8c3b1bbc by Nate Graham.
Committed on 13/04/2019 at 21:31.
Pushed by ngraham into branch 'master'.
When not displaying rating, leave more room for song title in playlist
Summary:
Currently the Playlist's ratings widget reserves space for itself for unrated songs,
which causes song titles to get elided even when there's plenty of space.
This patch hides the ratings widget for unrated songs, allowing the song title label
to have more space and not be elides as often.
This could become a problem in the future if there is ever a desire to set ratings
interactively by clicking on the ratings widget, but that's not implemented so for now
there's no issue (and probably a hover-based UI could make sense for that anyway).
Test Plan:
Now song titles for unrated songs have plenty of space, and rated songs display the same:
{F6770576}
Reviewers: mgallien, #elisa
Reviewed By: mgallien, #elisa
Differential Revision: https://phabricator.kde.org/D20511
M +2 -0 src/qml/PlayListEntry.qml
https://commits.kde.org/elisa/358086c2228945e84d0d60a1c94694ec8c3b1bbc
|