| Summary: | Improve grid delegates' hover button usability | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/elisa/761e3af65347072f12b770529a5effb6b39b6e58 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Grid delegates: Elisa vs Lollypop | ||
Git commit 761e3af65347072f12b770529a5effb6b39b6e58 by Nate Graham. Committed on 23/04/2019 at 02:56. Pushed by ngraham into branch 'master'. Revamp grid browser delegates to improve UI Summary: This patch changes the grid browser delegates in the following ways: - Labels are centered - Album art size increases from 100px to 170px, making the album view more attractive and leaving more room for labels - Hover buttons now appear in the corner, have borders, and no longer make the album art get washed out when the delegate is hovered - Some minor layout and positioning bugs are fixed As a result, the following bugs are fixed: Related: bug 406468 Also, the last usage of QQC1 in this component is removed as a side effect. Test Plan: Everything still works and there are no behavioral changes. {F6780036} Reviewers: mgallien, #elisa Reviewed By: mgallien, #elisa Differential Revision: https://phabricator.kde.org/D20581 M +83 -63 autotests/qmltests/tst_GridBrowserDelegate.qml M +2 -2 src/qml/BaseTheme.qml M +62 -61 src/qml/GridBrowserDelegate.qml https://commits.kde.org/elisa/761e3af65347072f12b770529a5effb6b39b6e58 |
Created attachment 119381 [details] Grid delegates: Elisa vs Lollypop Elisa from git master. The grid delegates in genre/artist/album views have three buttons that appear on mouse hover. However they suffer from some issues: - The grid delegates are quite small - The entire grid delegate is not clickable; you need to click on one of the individual icons - All three icons are the same size - When the icons appear, the art behind it becomes washed out and you can no longer see what it is I really like the way Lollypop handles this same situation. There, the grid delegates are larger, and the whole thing is always clickable; a click takes you into that item to the next level of navigation. However on hover, additional buttons appear allowing you to play all items in it or add it to the current playlist. These buttons cover up some of the art, but most of it is still visible. See attached comparison screenshot.