| Summary: | valgrind 3.15.0-RC1 fails cachegrind/callgrind ann tests because of missing a.c | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Mark Wielaard <mark> |
| Component: | general | Assignee: | Julian Seward <jseward> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | n.nethercote |
| Priority: | NOR | ||
| Version First Reported In: | 3.15 SVN | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
> +# They just serves as input for cg_annotate in ann1 and ann2.
s/serves/serve/
commit 08f20ed4afadf6134ca7e164416e98a1a60e0baa Author: Mark Wielaard <mark@klomp.org> Date: Tue Apr 9 14:47:05 2019 +0200 Add missing cachegrind/tests/a.c to EXTRA_DIST. cachegrind/callgrind fails ann[12] tests because of missing a.c These testcases fail because the dist tar is missing the a.c (auto-annotated) source file. Fix by adding it to EXTRA_DIST. https://bugs.kde.org/show_bug.cgi?id=406352 |
cachegrind/tests/ann1 (post) cachegrind/tests/ann2 (post) callgrind/tests/ann1 (post) callgrind/tests/ann2 (post) These testcases fail because the RC1 dist tar is missing the a.c (auto-annotated) source file. It is missing because it isn't listed in EXTRA_DIST. Proposed patch: diff --git a/cachegrind/tests/Makefile.am b/cachegrind/tests/Makefile.am index f2f8902..2722541 100644 --- a/cachegrind/tests/Makefile.am +++ b/cachegrind/tests/Makefile.am @@ -10,8 +10,8 @@ DIST_SUBDIRS = x86 . dist_noinst_SCRIPTS = filter_stderr filter_cachesim_discards -# Note that test.c is not compiled. It just serves as input for cg_annotate in -# ann1 and ann2. +# Note that test.c and a.c are not compiled. +# They just serves as input for cg_annotate in ann1 and ann2. EXTRA_DIST = \ cgout-test \ ann1.post.exp ann1.stderr.exp ann1.vgtest \ @@ -20,7 +20,7 @@ EXTRA_DIST = \ clreq.vgtest clreq.stderr.exp \ dlclose.vgtest dlclose.stderr.exp dlclose.stdout.exp \ notpower2.vgtest notpower2.stderr.exp \ - test.c \ + test.c a.c \ wrap5.vgtest wrap5.stderr.exp wrap5.stdout.exp check_PROGRAMS = \