| Summary: | Ekos solver options does not save --no-fits2fits option | ||
|---|---|---|---|
| Product: | [Applications] kstars | Reporter: | James Harrison <james> |
| Component: | general | Assignee: | Jasem Mutlaq <mutlaqja> |
| Status: | RESOLVED DOWNSTREAM | ||
| Severity: | minor | ||
| Priority: | NOR | ||
| Version First Reported In: | 3.1.1 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
James Harrison
2019-03-29 22:24:42 UTC
It's getting checked again because KStars detects an older astrometry.net that requires it. Are you trying ti uncheck it for the "remote" option? What version do you have on the machine running KStars? (In reply to Jasem Mutlaq from comment #1) > It's getting checked again because KStars detects an older astrometry.net > that requires it. Are you trying ti uncheck it for the "remote" option? What > version do you have on the machine running KStars? Aha! Right, this is all running locally and the local version is 0.77 from git (using the Arch AUR packaging: https://aur.archlinux.org/packages/astrometry.net/ ). The issue is in the Arch packaging. Looking at the OfflineAstrometryParser::init() function I see it's doing a shell out to bash, running solve-field --help | grep Revision and looking for a version number. I'm not sure what "good" looks like, but on my system that yields: Revision , date Tue_Nov_13_12:41:09_2018_+0800. From reading astronomy.net's code, after "Revision" should be the version tag and git commit hash but this doesn't get done in from-source builds, only in the release function. Even released source doesn't have this set, from my reading; the AUR package is just grabbing the source release and building it. I've worked around this by adding the following line to the AUR PKGBUILD's prepare function: sed "s/AN_GIT_REVISION .=.*/AN_GIT_REVISION := ${pkgver}/" -i util/makefile.common I will get this back into the AUR version. It's probably safer to default to not using --nofits2fits and assuming a modern build where there's no version information available, but this can be closed. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! Happy to report the AUR package for Arch is now building from the correct release source for astrometry.net and thus correctly sets its version string; KStars now correctly identifies it as not needing --nofits2fits and works out of the box. Thanks for the help! |