| Summary: | pyfalkon doesn't build with pyside 5.12.2 | ||
|---|---|---|---|
| Product: | [Applications] Falkon | Reporter: | Antonio Rojas <arojas> |
| Component: | extensions | Assignee: | David Rosca <nowrep> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 3.1.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/falkon/4b85dab3d7fa3ef267d043ee4cd37f78c5a8df50 | Version Fixed In: | 3.1.1 |
| Sentry Crash Report: | |||
|
Description
Antonio Rojas
2019-03-24 19:57:34 UTC
find_package(Shiboken2 "2.0.0") now fails: CMake Error at /usr/lib64/cmake/Shiboken2-5.12.2/shiboken_helpers.cmake:160 (shiboken_get_library_for_current_config): shiboken_get_library_for_current_config Function invoked with incorrect arguments for function named: shiboken_get_library_for_current_config Call Stack (most recent call first): /usr/lib64/cmake/Shiboken2-5.12.2/Shiboken2Config.cpython-37m-x86_64-linux-gnu.cmake:58 (shiboken_compute_python_libraries) /usr/lib64/cmake/Shiboken2-5.12.2/Shiboken2Config.cmake:5 (include) CMakeLists.txt:123 (find_package) It's broken in PySide though. Yeah, that's https://bugreports.qt.io/browse/PYSIDE-980 - set CMAKE_BUILD_TYPE to get to the real fun I've got it almost fixed, the only thing left is to link against correct Python libs. Let's see what's the verdict here https://bugreports.qt.io/browse/PYSIDE-982 Git commit 479933e095168d07a54913f88642cfed4828c167 by David Rosca. Committed on 25/03/2019 at 10:38. Pushed by drosca into branch 'Falkon/3.1'. PyFalkon: Fix build with Qt 5.12.2 FIXED-IN: 3.1.1 M +5 -5 CMakeLists.txt M +8 -10 src/plugins/PyFalkon/CMakeLists.txt https://commits.kde.org/falkon/479933e095168d07a54913f88642cfed4828c167 Great, but this breaks builds if you have still have pyside2 5.11, which is not really acceptable. (In reply to Rik Mills from comment #5) > Great, but this breaks builds if you have still have pyside2 5.11, which is > not really acceptable. Sorry, but tell that to Qt guys for breaking it. (In reply to David Rosca from comment #6) > (In reply to Rik Mills from comment #5) > > Great, but this breaks builds if you have still have pyside2 5.11, which is > > not really acceptable. > > Sorry, but tell that to Qt guys for breaking it. No, YOU broke builds with pyside2 < 5.12 with your commit Some logic in the cmake here should allow both cases. (In reply to Rik Mills from comment #7) > No, YOU broke builds with pyside2 < 5.12 with your commit > > Some logic in the cmake here should allow both cases. Sure, patches welcome. You can either disable building PyFalkon or revert this commit if you need to use old Qt. Git commit 4b85dab3d7fa3ef267d043ee4cd37f78c5a8df50 by David Rosca. Committed on 03/06/2019 at 15:42. Pushed by drosca into branch 'master'. Vertical tabs: Draw unloaded tabs with "Disabled" color palette Summary: BUG: 405833 Reviewers: #falkon Subscribers: falkon Tags: #falkon Differential Revision: https://phabricator.kde.org/D21548 M +4 -0 src/plugins/VerticalTabs/tabtreedelegate.cpp https://commits.kde.org/falkon/4b85dab3d7fa3ef267d043ee4cd37f78c5a8df50 |