| Summary: | old-style-connect: add support for converting QSignalSpy with PMF syntax | ||
|---|---|---|---|
| Product: | [Developer tools] clazy | Reporter: | David Faure <faure> |
| Component: | general | Assignee: | Sergio Martins <smartins> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | smartins |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/clazy/6eba9241b2c1f31c9ffc5bc0e19805b05d3e0ca1 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | testcase | ||
Git commit 1253cc3b596416435ba7581598eeca8655b2d09f by Sergio Martins. Committed on 04/04/2019 at 07:48. Pushed by smartins into branch 'master'. old-style-connect: Warn for QSignalSpy Fixit yet to come M +16 -6 src/checks/level2/old-style-connect.cpp M +4 -1 src/checks/level2/old-style-connect.h M +4 -0 tests/old-style-connect/config.json A +29 -0 tests/old-style-connect/port_qsignalspy.cpp [License: UNKNOWN] * A +4 -0 tests/old-style-connect/port_qsignalspy.cpp.expected The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. https://commits.kde.org/clazy/1253cc3b596416435ba7581598eeca8655b2d09f Git commit 6eba9241b2c1f31c9ffc5bc0e19805b05d3e0ca1 by Sergio Martins. Committed on 04/04/2019 at 08:23. Pushed by smartins into branch 'master'. old-style-connect: Added fixit for QSignalSpy too M +9 -8 src/checks/level2/old-style-connect.cpp M +4 -1 src/checks/level2/old-style-connect.h M +5 -0 tests/old-style-connect/config.json M +2 -0 tests/old-style-connect/port_qsignalspy.cpp.expected A +29 -0 tests/old-style-connect/port_qsignalspy.cpp_fixed.cpp.expected https://commits.kde.org/clazy/6eba9241b2c1f31c9ffc5bc0e19805b05d3e0ca1 |
Created attachment 118777 [details] testcase Technically not a connect(), but... would it be possible for old-style-connect to port QSignalSpy to the PMF syntax? My contribution is a patch that contains the unittest.