Bug 404322

Summary: No SVG file support for application menu icon
Product: [Plasma] kwin Reporter: Bobby Wibowo <bobbywibowo>
Component: auroraeAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: bugseforuns, doncbugs, hexclover, nate, trmdi, tusooa
Priority: NOR    
Version First Reported In: 6.1.5   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/kwin/-/commit/ca686f651a90f136ef887416fd318cc44624c356 Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Application menu button fallback to the app's icon

Description Bobby Wibowo 2019-02-14 07:47:44 UTC 
Created attachment 118056 [details]
Application menu button fallback to the app's icon

SUMMARY
Aurorae theme engine allows using SVG files to render window decorations, but there's a lack of support for "application menu" button.

When "application menu" button is added to the title bar, its icon will instead fallback to the app's icon.

If this file is indeed the one that loads Aurorae themes, https://phabricator.kde.org/source/kwin/browse/master/plugins/kdecorations/aurorae/src/lib/auroraetheme.cpp$111, then yeah, there doesn't seem to be any line in it whatsoever to load SVG file for "application menu" button.

This documentation also does not say anything about it, https://phabricator.kde.org/source/kwin/browse/master/plugins/kdecorations/aurorae/theme-description.

There used to be a bug report somewhat related to this, https://bugs.kde.org/show_bug.cgi?id=375862, but the proposed solution was only to allow adding the icon programmatically (which Plastik theme does).

STEPS TO REPRODUCE
1. Install an SVG-based Aurorae theme.
2. Go to System Settings > Application Style > Window Decorations.
3. Apply the said theme in Theme tab.
4. Go to Buttons tab, then add Application menu button somewhere in the title bar.

OBSERVED RESULT
Application menu button fallback to the app's icon instead of trying to load an SVG icon from the theme.
Then again there's no support for it anyway.

EXPECTED RESULT
Application menu button supports SVG file.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon 5.14
KDE Plasma Version: 5.15.0
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.0

ADDITIONAL INFORMATION
Relevant issue in an SVG-based theme's Github repository: https://github.com/PapirusDevelopmentTeam/materia-kde/issues/37.
Comment 1 Patrick Silva 2019-02-14 13:28:23 UTC 
it seems related to bug 381442
Comment 2 Nate Graham 2019-02-14 21:29:28 UTC 
No, that's something else.
Comment 3 trmdi 2019-09-06 01:26:46 UTC 
I think this should be fixed because people use Aurorae theme a lot, and putting the Menu icon on the titlebar is a common usage.
Comment 4 Vlad Zahorodnii 2019-09-06 08:08:38 UTC 
> I think this should be fixed
As pretty much any other bug...
Comment 5 tusooa 2024-09-26 03:37:53 UTC 
Can reproduce on 6.1.5 . I will try to give a fix.
Comment 6 Bug Janitor Service 2024-09-26 21:24:15 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6528
Comment 7 Vlad Zahorodnii 2024-09-27 19:30:17 UTC 
Git commit ca686f651a90f136ef887416fd318cc44624c356 by Vlad Zahorodnii, on behalf of tusooa the west wind.
Committed on 27/09/2024 at 19:20.
Pushed by vladz into branch 'master'.

Add app menu svg support for aurorae

This adds support for a proper app menu icon for aurorae svg
decorations. The appmenu.svg(z) file will be used for the icon if it
exists. If not, it will fallback to the window's icon, the same as
before.

M  +2    -0    src/plugins/kdecorations/aurorae/src/lib/auroraetheme.cpp
M  +2    -0    src/plugins/kdecorations/aurorae/src/lib/auroraetheme.h
M  +15   -4    src/plugins/kdecorations/aurorae/src/qml/AppMenuButton.qml
M  +3    -0    src/plugins/kdecorations/aurorae/src/qml/AuroraeButton.qml

https://invent.kde.org/plasma/kwin/-/commit/ca686f651a90f136ef887416fd318cc44624c356