| Summary: | In search lists (and only search lists) rating indication on delegate and on app page aren't synchronized with actual reviews' ratings | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Alexander Mentyu <notuxius> |
| Component: | discover | Assignee: | Aleix Pol <aleixpol> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | normal | CC: | bugseforuns, nate |
| Priority: | HI | ||
| Version: | 5.15.3 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
No rating from review in kmag app
screen recording |
||
Confirmed, this drives me crazy. Hmm, now with git master I actually can't reproduce this anymore! Let's close it and re-open if we see it again. This bug persists on neon dev unstable. Really? I don't see it. Any chance you could attach a screen recording? Created attachment 118889 [details]
screen recording
Ah I see the problem. The ratings are synchronized on the Featured page and in the browse lists, but not in the search lists. I can confirm. Here the problem also occurs in the browse lists. Both Geogebra and kmag apps are affected. Nate, are you sure it depends on the list? To me it seems like the ratings page isn't being generated properly. See kmag isn't listed at all here: https://odrs.gnome.org/1.0/reviews/api/ratings I don't see how it could depend on the view or state of Discover. I'll reach out to ODRS maintainer. For reference, this is the (one?) review we can't see as a rating: https://odrs.gnome.org/admin/review/8220 Confirmed, I no longer see a difference between the ratings on search results pages vs other pages. Maybe I never did... Should this stay open, or is it 100% ODRS's fault? https://gitlab.gnome.org/Infrastructure/odrs-web/blob/master/app_data/odrs/views_api.py#L498 This shows that in order to have ratings we need to have reviews. Let's review what we care about! :) |
Created attachment 117707 [details] No rating from review in kmag app STEPS TO REPRODUCE 1. Open 'Applications' page. 2. Open 'Accessibility' page. 3. Open for example gXNeur or kmag app page. OBSERVED RESULT 'No ratings yet' text is displayed below app name - but there is rating in the review of the app. EXPECTED RESULT Rating from reviews is displayed below app name. SOFTWARE/OS VERSIONS Operating System: KDE neon Developer Edition KDE Plasma Version: 5.15.80 KDE Frameworks Version: 5.54.0 Qt Version: 5.11.2 Kernel Version: 4.15.0-42-generic