| Summary: | Add hover and pressed states in list view's buttons | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | matheus4551 |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | nate |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | Not decided | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kirigami/bdb5465181b6e03ff0141111d3da95791121e15d | Version Fixed In: | 5.56 |
|
Description
matheus4551
2019-01-26 21:55:53 UTC
Huge +1. Looks like the problem is that these buttons are basically custom-synthesized fake toolbuttons instead of real toolbuttons. I'll see what I can do. Wasn't as hard as I thought. Here's a patch: https://phabricator.kde.org/D18908 Git commit bdb5465181b6e03ff0141111d3da95791121e15d by Nate Graham.
Committed on 11/02/2019 at 16:02.
Pushed by ngraham into branch 'master'.
[SwipeListItem] Use a real toolbutton to improve usability
Summary:
Use a real toolbutton instead of a custom icon + mouse area, which
provides hovered and clicked states automatically and simplifies
the code a bit.
FIXED-IN: 5.56
Test Plan:
Hovered state: {F6605906, size=full}
Pressed state: {F6605907, size=full}
Reviewers: mart, #kirigami
Reviewed By: mart, #kirigami
Subscribers: apol, plasma-devel
Tags: #kirigami
Differential Revision: https://phabricator.kde.org/D18908
M +15 -23 src/controls/templates/SwipeListItem.qml
https://commits.kde.org/kirigami/bdb5465181b6e03ff0141111d3da95791121e15d
|