Bug 403295

Summary: Bookmark icon over dark background almost invisible
Product: [Frameworks and Libraries] frameworks-ktexteditor Reporter: Gabriele Menna <gabmen>
Component: generalAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: a.samirh78, aspotashev, loh.tar, nate, noahadvs
Priority: HI    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: a screenshot of a pretty invisible bookmark icon over dark background
Sides of bookmark icon are cut off
Breeze Dark bookmark icon with Kate's Normal Color Scheme

Description Gabriele Menna 2019-01-17 07:30:00 UTC
Created attachment 117500 [details]
a screenshot of a pretty invisible bookmark icon over dark background

Bookmark icon, which appears when clicking on the icon border of a text editor instance, is almost invisible, when using a dark background.
Comment 1 Noah Davis 2019-01-18 20:39:18 UTC
Created attachment 117550 [details]
Sides of bookmark icon are cut off
Comment 2 Noah Davis 2019-01-18 20:41:14 UTC
Created attachment 117551 [details]
Breeze Dark bookmark icon with Kate's Normal Color Scheme
Comment 3 Noah Davis 2019-01-18 20:43:22 UTC
It seems there are 2 issues here.

1. The icon is displayed incorrectly (Attachment 2 [details])
2. The icon follows the system color scheme, not the text editor color scheme.
Comment 4 Ahmad Samir 2019-03-02 17:11:32 UTC
The color part, might be a similar issue to bug 403496; could you try the stuff in bug 403496 comment3?
Comment 5 Gabriele Menna 2019-03-13 08:57:48 UTC
I suppose I got where the problem is.

I'm using a ligth color schema for application and icons (Breeze), but a dark dark one for text editor (Breeze Dark).

And breeze bookmark icon becomes pretty invisible over a dark background...
Comment 6 Lothar 2019-04-30 21:12:45 UTC
> 1. The icon is displayed incorrectly
Did not look at your attachement, but guess I know the issue. Tried two times to fix that, looks here good now

https://cgit.kde.org/ktexteditor.git/commit/?id=08d1537b756513face11338a365d7617aea38e5c

With you comment #5 you may consider to close this
Comment 7 Nate Graham 2019-05-01 02:27:15 UTC
Yep, looks like that fixed it. Thanks!