Summary: | Dolphin error when save file from loaded on FTP | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Nicolas <nico357> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | alfeno, asturm, danailster, elvis.angelaccio, johnnyftlopes, johnnyrevenge, kde, kde, kdelibs-bugs-null, oded |
Priority: | NOR | Keywords: | drkonqi |
Version First Reported In: | git master | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio/b8a5f34b34b6c4e37684fe2782b8cf39c38cd928 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: | New crash information added by DrKonqi |
Description
Nicolas
2018-12-28 19:11:11 UTC
*** Bug 403063 has been marked as a duplicate of this bug. *** Git commit cd2f67c39b25de026390bfe2bc1c7aa269f78ccb by David Edmundson. Committed on 12/01/2019 at 08:05. Pushed by davidedmundson into branch 'master'. Fix elapsed time check Summary: To match the code it was refactored from it should be checking the code since the last time we checked calcSpeed, not since the job started. Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D18158 M +3 -1 src/core/slaveinterface.cpp https://commits.kde.org/kio/cd2f67c39b25de026390bfe2bc1c7aa269f78ccb *** Bug 403084 has been marked as a duplicate of this bug. *** Patch seems to fix it. It's not in 5.54.0 Created attachment 117456 [details]
New crash information added by DrKonqi
dolphin (18.12.1) using Qt 5.11.3
This crash was reproduced again with the patch from commit cd2f67c39b25de026390bfe2bc1c7aa269f78ccb included.
-- Backtrace (Reduced):
#6 0x00007f85d11f4b82 in KIO::SlaveInterface::calcSpeed (this=0x55cad3ffac60) at /var/tmp/portage/kde-frameworks/kio-5.54.0/work/kio-5.54.0/src/core/slaveinterface.cpp:115
#7 0x00007f85d11f6fd0 in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (KIO::SlaveInterface::*)()>::call(void (KIO::SlaveInterface::*)(), KIO::SlaveInterface*, void**) (arg=<optimized out>, o=<optimized out>, f=<optimized out>) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:166
#8 QtPrivate::FunctionPointer<void (KIO::SlaveInterface::*)()>::call<QtPrivate::List<>, void>(void (KIO::SlaveInterface::*)(), KIO::SlaveInterface*, void**) (arg=<optimized out>, o=<optimized out>, f=<optimized out>) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:167
#9 QtPrivate::QSlotObject<void (KIO::SlaveInterface::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=<optimized out>, this_=<optimized out>, r=<optimized out>, a=<optimized out>, ret=<optimized out>) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:396
#10 0x00007f85cd2cc600 in QtPrivate::QSlotObjectBase::call (a=0x7ffee72eaf90, r=0x55cad3ffac60, this=0x55cad4011e00) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:376
Git commit b8a5f34b34b6c4e37684fe2782b8cf39c38cd928 by Fabian Vogt. Committed on 14/01/2019 at 12:38. Pushed by fvogt into branch 'master'. Revert "Refactor SlaveInterface::calcSpeed" This reverts commit 4e2a815b9a107663a3d75e9d9d1be336adea888e. This commit causes crashes due to improper division and there are some outstanding code review issues as well. M +31 -17 src/core/slaveinterface.cpp M +8 -11 src/core/slaveinterface_p.h https://commits.kde.org/kio/b8a5f34b34b6c4e37684fe2782b8cf39c38cd928 *** Bug 403206 has been marked as a duplicate of this bug. *** *** Bug 403213 has been marked as a duplicate of this bug. *** *** Bug 403218 has been marked as a duplicate of this bug. *** *** Bug 403257 has been marked as a duplicate of this bug. *** |