| Summary: | Text cursor disappears or doesn't move | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Nikos Chantziaras <realnc> |
| Component: | kpart | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | asturm, awilfox, ilya, m.j.everitt, martin.sandsmark, nate, wbauer1 |
| Priority: | NOR | ||
| Version: | 18.12.1 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/konsole/9af659c73e3203e1d5ef3873fa6c0144258b9673 | Version Fixed In: | 19.04.0 |
| Sentry Crash Report: | |||
|
Description
Nikos Chantziaras
2018-12-26 18:38:51 UTC
Thanks - Martin can you look at this? *** Bug 404973 has been marked as a duplicate of this bug. *** If you have problems reproducing, try using a bitmap font. *** Bug 404873 has been marked as a duplicate of this bug. *** This fixes it for me: https://phabricator.kde.org/D19513 (In reply to Wolfgang Bauer from comment #5) > This fixes it for me: > https://phabricator.kde.org/D19513 Same here. Applied to 18.12.2 and it fixes the issue. Git commit eccfb1f62bbf67ebffee11e241bd05757b826ff1 by Kurt Hindenburg, on behalf of Wolfgang Bauer.
Committed on 05/03/2019 at 14:37.
Pushed by hindenburg into branch 'master'.
Fix ibeam and underline cursor rendering
Summary:
Since anti-aliasing was enabled in the painter, coordinates need to
be shifted half a pixel so that they align with the pixel grid,
otherwise the result gets "blurred" due to the anti-aliasing.
And as parts of the blurred shape leak outside the cursor rectangle,
this also leaves artifacts when the cursor moves or blinks as these
parts are not cleared.
This is basically the same as commit
e7085310d6d594823d0ed491fa8bdbd99dec4932 for the
standard block cursor.
Test Plan:
- Switch cursor shape to "I-Beam" or "Underline" in the "Advanced"
profile settings
The cursors are a single line again now, before they were blurred by
anti-aliasing.
Screenshots:
Before:
{F6656366}
{F6656370}
After:
{F6656371}
{F6656373}
Also, there are no more artifacts when the cursor is moved or
cursor blinking is enabled.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D19513
M +10 -8 src/TerminalDisplay.cpp
https://commits.kde.org/konsole/eccfb1f62bbf67ebffee11e241bd05757b826ff1
Git commit 9af659c73e3203e1d5ef3873fa6c0144258b9673 by Kurt Hindenburg, on behalf of Wolfgang Bauer.
Committed on 07/03/2019 at 01:32.
Pushed by hindenburg into branch 'Applications/18.12'.
Fix ibeam and underline cursor rendering
Summary:
Since anti-aliasing was enabled in the painter, coordinates need to
be shifted half a pixel so that they align with the pixel grid,
otherwise the result gets "blurred" due to the anti-aliasing.
And as parts of the blurred shape leak outside the cursor rectangle,
this also leaves artifacts when the cursor moves or blinks as these
parts are not cleared.
This is basically the same as commit
e7085310d6d594823d0ed491fa8bdbd99dec4932 for the
standard block cursor.
Test Plan:
- Switch cursor shape to "I-Beam" or "Underline" in the "Advanced"
profile settings
The cursors are a single line again now, before they were blurred by
anti-aliasing.
Screenshots:
Before:
{F6656366}
{F6656370}
After:
{F6656371}
{F6656373}
Also, there are no more artifacts when the cursor is moved or
cursor blinking is enabled.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D19513
(cherry picked from commit eccfb1f62bbf67ebffee11e241bd05757b826ff1)
M +10 -8 src/TerminalDisplay.cpp
https://commits.kde.org/konsole/9af659c73e3203e1d5ef3873fa6c0144258b9673
|