| Summary: | Digital Clock settings inappropriately use tri-state checkbox for 12/24 hour time display | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Andres Betts <anditosan1000> |
| Component: | Digital Clock widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | anditosan1000, kde, nate, plasma-bugs-null |
| Priority: | NOR | Keywords: | triaged |
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-workspace/74f0f259465543e52ad93aed2d2fb8471c9f9777 | Version Fixed/Implemented In: | 5.16.0 |
| Sentry Crash Report: | |||
|
Description
Andres Betts
2018-12-23 06:56:48 UTC
BTW, cannot reproduce. I don't have a half-step checkbox; only on and off. >BTW, cannot reproduce. I don't have a half-step checkbox; only on and off.
It's a default until a user modifies it.
It means "follow system" - which will either be the same as on or off depending on the locale.
Might be worth taking a step back for other solutions.
I would just suggest a disclaimer below the checkbox Thanks David! A half-checked checkbox generally means "some things are selected, but not others." Using it for this UI isn't ideal. In this case, a combobox or a radio button would be better UI, with the options being on, off, and use locale/system default. I can agree with that too Something like this:
Time display: Use locale default
24-hour
12-hour
Here's a patch: https://phabricator.kde.org/D19230 Git commit 74f0f259465543e52ad93aed2d2fb8471c9f9777 by Nate Graham.
Committed on 28/02/2019 at 21:36.
Pushed by ngraham into branch 'master'.
[Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox
Summary:
The use of a tri-state checkbox for the three possible states (12hr, 24hr, use locale
default) is not ideal because it violates the convention regarding what tri-state
checkboxes are used for: nested lists where some sub-items can be unselected.
This patch replaces it with a combobox that clearly indicates all three states.
While we're at it, we add a button to open the Formats KCM in case people want to change their region.
FIXED-IN: 5.16.0
Test Plan:
Tested functionality with `en_US` locale. Check out the clock in the bottom-right corner of
the following screenshots:
Default state: "Use Region Defaults": {F6645570}
Force 12 hour time: {F6645573}
Force 24-hour time: {F6645574}
Reviewers: #plasma, Zren, #vdg, davidedmundson, ndavis
Reviewed By: #plasma, #vdg, davidedmundson, ndavis
Subscribers: cfeck, totte, ndavis, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19230
M +27 -7 applets/digital-clock/package/contents/ui/configAppearance.qml
https://commits.kde.org/plasma-workspace/74f0f259465543e52ad93aed2d2fb8471c9f9777
|