| Summary: | install might cause a segfault | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kpackage | Reporter: | Maximiliano Curia <maxy> |
| Component: | default | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | alexander.lohnau, leinir, nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Package-might-be-gone.patch | ||
I'm sorry that your bug report and patch got missed, however this is why we encourage people to submit patches officially. See https://community.kde.org/Infrastructure/GitLab However, is this still a problem? The autotest is succeeding for me. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |
Created attachment 116150 [details] Package-might-be-gone.patch SUMMARY With the introduction of "Emit signals when a package is installed/uninstalled" (b42973d964df159119467030689f36cc005715b5) the autotest PlasmoidPackageTest::noCrashOnAsyncInstall started failing since the test is explicitly making sure the package is destroyed before the install job is executed. The new connect code in the install procedure uses the package which, in this case is a nullptr. This is supposedly how it's in use by plasmashell (according to the test description). The attached patch is a workaround that assumes that the package won't become nullptr while handling the connect, thus it's not perfect. This issue seems to be easily reproducible running the autotests, it would be nice if the autotests are actually tested, at least on release. Happy hacking,