Bug 400516

Summary: In desktop mode, sheets should not quite touch the sides of the content view
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Nate Graham <nate>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 5.53
Sentry Crash Report:
Attachments: How sheets look on the desktop

Description Nate Graham 2018-10-31 14:41:43 UTC
Created attachment 116004 [details]
How sheets look on the desktop

See attached image, which depicts how Kirigami sheets look right now in desktop mode.

I think the visual style would be improved if the sides of the sheet were not anchored to the sides of the parent view. If there were a bit of padding there instead, then the sheet would seem like it's floating in the parent view, which I think would look better.
Comment 1 Nate Graham 2018-10-31 15:16:02 UTC
Heck, maybe we should do this on Mobile too (with smaller margins, obviously), just to reinforce the distinctions between pages (full screen) and sheets (not full screen).
Comment 2 Nate Graham 2018-11-26 16:51:04 UTC
This was fixed in Kirigami recently: https://cgit.kde.org/kirigami.git/commit/?id=337ba709a179dd53187564411fa0109f16d0ceae