| Summary: | Star icon missing from download button | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | retired <pepko94> |
| Component: | kcm_sddm | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | 5.14.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/sddm-kcm/de088bdca917e833176e9beff7407b47ffed8e58 | Version Fixed In: | 5.15.0 |
| Sentry Crash Report: | |||
| Attachments: | further explanation | ||
Here's a patch: https://phabricator.kde.org/D16497 Git commit de088bdca917e833176e9beff7407b47ffed8e58 by Nate Graham.
Committed on 28/10/2018 at 22:49.
Pushed by ngraham into branch 'master'.
Give the GHNS button an appropriate icon and more consistent text
Summary:
This patch gives the GHNS button an icon and tweaks its text to be consistent with the general pattern seen in other KCMs.
FIXED-IN: 5.15.0
Test Plan: {F6371684}
Reviewers: #plasma, #vdg, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16497
M +4 -1 src/ui/themeconfig.ui
https://commits.kde.org/sddm-kcm/de088bdca917e833176e9beff7407b47ffed8e58
|
Created attachment 115949 [details] further explanation SUMMARY All kcms that provide store.kde.org integration have star icon on download button. SDDM kcm seems to be missing that detail. SOFTWARE VERSIONS (available in About System) KDE Plasma Version: 5.14.2 KDE Frameworks Version: 5.51.0 Qt Version: 5.11.2 Locale set to pl_PL, also tested with en_US just to make sure it's not problem with locale.