| Summary: | Installed snaps don't have an icon | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Patrick Silva <bugseforuns> |
| Component: | Snap Backend | Assignee: | Aleix Pol <aleixpol> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kirigami/19d09d1ef958b68b8de56965b97d647cfe4ea7b6 | Version Fixed In: | 5.62 |
| Attachments: |
screenshot
list of installed snaps |
||
Created attachment 115903 [details]
list of installed snaps
icons are also wrong in the list of installed Snaps under "Settings".
First one is already fixed in kirigami master. The second isn't so I'll rename the bug. Git commit 19d09d1ef958b68b8de56965b97d647cfe4ea7b6 by Aleix Pol. Committed on 06/08/2019 at 13:42. Pushed by apol into branch 'master'. Kirigami.Icon: Fix loading bigger images when source is a URL Summary: Port to using the QImage::load() that takes a QIODevice and only do it when the execution is finished, instead of upon readyRead(). This makes sure that we are only processing the icon when is fully downloaded. Related: bug 407409 Test Plan: Reproduced the bug and fixed it Reviewers: #frameworks, #kirigami, mart Reviewed By: #kirigami, mart Subscribers: broulik, plasma-devel Tags: #kirigami Differential Revision: https://phabricator.kde.org/D22952 M +36 -42 src/icon.cpp M +2 -2 src/icon.h https://commits.kde.org/kirigami/19d09d1ef958b68b8de56965b97d647cfe4ea7b6 |
Created attachment 115902 [details] screenshot STEPS TO REPRODUCE 1. open Discover and search for something, let's say "photos" 2. 3. OBSERVED RESULT Snap packages listed in the search results have wrong icon. The icon is correct in their description page. See the screenshot. EXPECTED RESULT Snaps have correct icon in the search results. KDE neon Developer Edition KDE Plasma: 5.14.80 Qt: 5.11.2 KDE Frameworks: 5.52.0