| Summary: | Don't show a popup notification when a network connection is activated on login (after that is fine though) | ||
|---|---|---|---|
| Product: | [Plasma] plasma-nm | Reporter: | Tyson Tan <tysontanx> |
| Component: | applet | Assignee: | Jan Grulich <jgrulich> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, claudius.ellsel, jgrulich, kde, nate, ncqm3qdz, plasma-bugs |
| Priority: | HI | Keywords: | usability |
| Version: | 5.13.5 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=399974 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-nm/commit/622f53da6184dc90d5834a9e75fb1cb1c3af5986 | Version Fixed In: | 5.24.2 |
|
Description
Tyson Tan
2018-10-18 08:10:08 UTC
It makes sense to have it when you manually click connect (or does it, given the status changes right in the plasmoid) but it definitely shouldn't show it every time you log in. Agreed, no need to show a connection notification on login--only after that. *** Bug 375045 has been marked as a duplicate of this bug. *** I did some search and I guess this is the corresponding function needing adjustments, correct? https://phabricator.kde.org/source/plasma-nm/browse/master/kded/notification.cpp$371 Yes, that would need to check for whether the user just clicked the "Disconnect" button to produce the action that changed state and generated a notification, and if so, don't send the notification. I guess you meant "only show a notification if the user pressed connect button before"? I am not sure whether there are other ways how a connection could get established where a notification might be wanted. I guess more foolproof would be to somehow detect whether it was activated (automatically) right after login. Unfortunately I don't know how that can be achieved. *** Bug 448440 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/105 Git commit bd5078d8a5d6dea351339641ab8be3a392039ce8 by Fushan Wen, on behalf of Nate Graham. Committed on 20/02/2022 at 02:59. Pushed by fusionfuture into branch 'master'. kded: don't show "connection activated" notifications on launch/login The daemon connects to NetworkManager::ActiveConnection::stateChanged signals to show notifications, and this signal gets emitted when the daemon launches to first make its connection. As a result, every time the user logs in or the plasma-nm kded module is restarted (manually or due to a crash), a "Connection activated" notification is shown. This is annoying and redundant since the connection was made with no user action taken; the user *expects* background processes to work normally and does not need to be explicitly notified of it. Plasma-nm already has some logic to suppress these notifications that would be sent within the first 10 seconds after waking up from sleep, but it does not handle the case of the same thing happening right when the daemon is launched (e.g. on login). This commit makes it handle that use case as well, with the same approach: suppressing "activated" notifications sent within the first 10 seconds. FIXED-IN: 5.24.2 M +15 -0 kded/notification.cpp M +1 -0 kded/notification.h https://invent.kde.org/plasma/plasma-nm/commit/bd5078d8a5d6dea351339641ab8be3a392039ce8 Git commit 622f53da6184dc90d5834a9e75fb1cb1c3af5986 by Fushan Wen, on behalf of Nate Graham. Committed on 20/02/2022 at 10:14. Pushed by fusionfuture into branch 'Plasma/5.24'. kded: don't show "connection activated" notifications on launch/login The daemon connects to NetworkManager::ActiveConnection::stateChanged signals to show notifications, and this signal gets emitted when the daemon launches to first make its connection. As a result, every time the user logs in or the plasma-nm kded module is restarted (manually or due to a crash), a "Connection activated" notification is shown. This is annoying and redundant since the connection was made with no user action taken; the user *expects* background processes to work normally and does not need to be explicitly notified of it. Plasma-nm already has some logic to suppress these notifications that would be sent within the first 10 seconds after waking up from sleep, but it does not handle the case of the same thing happening right when the daemon is launched (e.g. on login). This commit makes it handle that use case as well, with the same approach: suppressing "activated" notifications sent within the first 10 seconds. FIXED-IN: 5.24.2 (cherry picked from commit bd5078d8a5d6dea351339641ab8be3a392039ce8) M +15 -0 kded/notification.cpp M +1 -0 kded/notification.h https://invent.kde.org/plasma/plasma-nm/commit/622f53da6184dc90d5834a9e75fb1cb1c3af5986 Thank you, guys! |