| Summary: | Missing icon in "Configure..." button | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
| Component: | Weather | Assignee: | Friedrich W. H. Kossebau <kossebau> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, plasma-bugs, thomas.surrel |
| Priority: | NOR | ||
| Version: | 5.14.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kdeplasma-addons/bd558d122885aa7119a5acc2f787e868c2436100 | Version Fixed In: | 5.14.2 |
| Attachments: | screenshot | ||
Have a patch: https://phabricator.kde.org/D16287 Git commit bd558d122885aa7119a5acc2f787e868c2436100 by Nate Graham.
Committed on 18/10/2018 at 12:51.
Pushed by ngraham into branch 'master'.
[Comics & Weather widgets] give "Configure..." buttons icons
Summary:
This patch gives the Comics and Weather widgets appropriate icons for their {nav Configure...} buttons.
FIXED-IN: 5.14.2
Test Plan:
{F6335981}
(Weather on top, Comics on bottom)
Note that the size discrepancy appears to be an unrelated `PlasmaComponents3` bug: https://bugs.kde.org/show_bug.cgi?id=399952 (The Weather widget uses PC3, while the Comics widget uses PC2)
Reviewers: #plasma, kossebau, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16287
M +1 -0 applets/comic/package/contents/ui/main.qml
M +1 -0 applets/weather/package/contents/ui/FullRepresentation.qml
https://commits.kde.org/kdeplasma-addons/bd558d122885aa7119a5acc2f787e868c2436100
|
Created attachment 115681 [details] screenshot STEPS TO REPRODUCE 1. add weather report widget to your desktop 2. 3. OBSERVED RESULT See my screenshot please. On top is weather report, on bottom is media frame widget. "Configure..." button of weather report has no icon. EXPECTED RESULT "Configure..." button of the weather report widget should have the same icon as the button of the media frame widget. SOFTWARE VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.14.1 Qt Version: 5.11.2 KDE Frameworks Version: 5.51.0