| Summary: | user-trash should not look like a folder at large sizes | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Nate Graham <nate> |
| Component: | Icons | Assignee: | visual-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andrew.crouthamel, bugseforuns, codezela, ivan.cukic, kainz.a, noahadvs, sven |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/breeze-icons/d970e61493a6ff648350e8cf53a19372c9847505 | Version Fixed/Implemented In: | 5.62 |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2018-10-10 14:23:49 UTC
+1 Yes please. This was an issue I ran into a while ago when doing work for Gwenview. (In reply to Nate Graham from comment #0) > Right now the `user-trash` icon looks like a trash can at small sizes but > starts looking like a folder with a trash icon in it at large sizes. This is > undesirable; the trash is really not something to be thought of as a folder. > We should make its large size stop looking like a folder. Instead, it should > be a pretty full-color Breeze-style trash can. I thought the trash was a folder? If that is not how it works, then I agree. If it is a folder, then I think the icon should stay a folder. > I thought the trash was a folder?
Even if it was, that is a technicality. The icon should reflect what it is used as, and it is not used as a normal folder.
(In reply to Ivan Čukić from comment #3) > > I thought the trash was a folder? > > Even if it was, that is a technicality. The icon should reflect what it is > used as, and it is not used as a normal folder. Exactly. *** Bug 411516 has been marked as a duplicate of this bug. *** Git commit d970e61493a6ff648350e8cf53a19372c9847505 by Noah Davis.
Committed on 03/09/2019 at 13:54.
Pushed by ndavis into branch 'master'.
Make user-trash icons look like trashcans
Summary: BUG: 399613
Test Plan:
{F7309835, size=full}
{F7309836, size=full}
Reviewers: #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23685
M +56 -23 icons-dark/places/32/user-trash-full.svg
M +40 -23 icons-dark/places/32/user-trash.svg
M +56 -23 icons-dark/places/64/user-trash-full.svg
M +40 -23 icons-dark/places/64/user-trash.svg
M +56 -23 icons/places/32/user-trash-full.svg
M +40 -23 icons/places/32/user-trash.svg
M +56 -23 icons/places/64/user-trash-full.svg
M +40 -23 icons/places/64/user-trash.svg
https://commits.kde.org/breeze-icons/d970e61493a6ff648350e8cf53a19372c9847505
|