| Summary: | User should be able to start typing to search after pressing Ctrl+F | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Matej Mrenica <matejm98mthw> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | matejm98mthw |
| Priority: | NOR | ||
| Version: | 0.3.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
Matej Mrenica
2018-09-16 13:37:58 UTC
I will fix it. (In reply to Matthieu Gallien from comment #1) > I will fix it. Thanks, in addition to this, could we also skip the need to use Ctrl+F, or is that too much? (In reply to mthw0 from comment #2) > (In reply to Matthieu Gallien from comment #1) > > I will fix it. > > Thanks, in addition to this, could we also skip the need to use Ctrl+F, or > is that too much? What do you mean exactly ? Is it that one could start typing as soon as the grid view is focused ? Yes, exactly. I have posted a review that covers the need to have focus in the test entry control when pressing the shortcut to show the search bar. https://phabricator.kde.org/D15607 Could this still make it into Elisa 0.3.0? (In reply to mthw0 from comment #6) > Could this still make it into Elisa 0.3.0? Yes this is the intended target. Git commit 3f15d516b98003e4a70ba2af368f8fa834104f07 by Matthieu Gallien. Committed on 23/09/2018 at 19:55. Pushed by mgallien into branch '0.3'. Gives immediate focus to the search entry control after pressing the shortcut to show it Summary: when showing the filter panel, give it focus immediately clean up the logic behind the filter bar expanded and collapsed states Test Plan: pressing the shortcut gives focus Reviewers: astippich, januz, ognarb Reviewed By: astippich Tags: #elisa Differential Revision: https://phabricator.kde.org/D15607 M +16 -20 autotests/qmltests/tst_NavigationActionBar.qml M +0 -66 src/qml/ContentView.qml M +0 -13 src/qml/ElisaMainWindow.qml M +0 -3 src/qml/FileBrowserView.qml M +0 -3 src/qml/GridBrowserView.qml M +0 -3 src/qml/ListBrowserView.qml M +11 -3 src/qml/NavigationActionBar.qml https://commits.kde.org/elisa/3f15d516b98003e4a70ba2af368f8fa834104f07 Version 0.3.0 provides the fix so I am closing this. |