| Summary: | Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | auronhines |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, halla |
| Priority: | NOR | ||
| Version First Reported In: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/krita/127857b20cfdf5bee58599cf8a0bef74d6510fd0 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Info
patch, |
||
If you'd provide a patch, I'd apply it, but it is not a bug in Krita. Created attachment 115078 [details]
patch,
Here's the patch, If it breaks it let me know.
Git commit 127857b20cfdf5bee58599cf8a0bef74d6510fd0 by Boudewijn Rempt. Committed on 18/09/2018 at 14:58. Pushed by rempt into branch 'master'. Remove places where cat doesn't need to be used M +4 -4 kundo2_aware_xgettext.sh https://commits.kde.org/krita/127857b20cfdf5bee58599cf8a0bef74d6510fd0 Where can i add these in the future? Patches (but please use git diff to create a patch, instead of attaching the complete file) can go on phabricator.kde.org It broke. scripty is unhappy extragear-graphics_krita /home/scripty/prod/trunk/l10n-kf5/templates/messages/extragear-graphics kundo2_aware_xgettext.sh: line 39: file: No such file or directory let me see what died Ah I didn't add > to the end of cat. Albert, did it ever work and is the file being pointed at right? Even correcting some spelling still has it broken (So i forgot to do cat > sorry) Oh god... I'm using Cat not cmd WHYYY Rigth, I'll just revert this -- "useless cat" isn't important. I only know it as an ancient comp.os.unix usenet meme... I don't think i'm to blame actually. After the revert the error still shows on Travis-cl /home/travis/.travis/job_stages: line 98: ./configure: No such file or directory And I don't have a git cmd I can use but I need a diff to create a diff using phabricator What does travis have to do with this? I used it to test the build and can you answer my question please? IDK how to. I am not sure I understand your question. Are you asking for git diff? or arc diff? git diff |
Created attachment 114986 [details] Info Dir: /source/master/kundo2_aware_xgettext.sh Lines: 39, 83, 84, 85