| Summary: | Widget paddings/margins wrong | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] print-manager | Reporter: | Sefa Eyeoglu <contact> |
| Component: | applet | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | kde, nate, plasma-bugs |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=360199 | ||
| Latest Commit: | https://commits.kde.org/print-manager/faea0b125911820c2c574cf17457f2d15c6100ba | Version Fixed In: | 20.04.0 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot of the widget | ||
Submitted a patch to fix this: https://phabricator.kde.org/D27995 Git commit faea0b125911820c2c574cf17457f2d15c6100ba by Nate Graham. Committed on 12/03/2020 at 18:55. Pushed by ngraham into branch 'master'. [Applet] Fix list item margins Summary: Related: bug 360199 FIXED-IN: 20.04.0 This is a minimal change needed to fix the aforementioned bugs. Ultimately I would like to make a re-usable component to implement this "expandable list item" paradigm (which is also used in the Networks, Bluetooth, Vaults, and Device Notifier applets) so we don't have to maintain five versions of the code. See T12812. Test Plan: Before: {F8171128} After: {F8171127} Reviewers: #plasma, dantti, cblack, ndavis Reviewed By: cblack, ndavis Subscribers: cblack, sefaeyeoglu, kde-utils-devel Differential Revision: https://phabricator.kde.org/D27995 M +5 -9 plasmoid/package/contents/ui/PrinterItem.qml https://commits.kde.org/print-manager/faea0b125911820c2c574cf17457f2d15c6100ba |
Created attachment 114981 [details] Screenshot of the widget The items in the print-manager widget (in the systray) have weird paddings/margins. The icons and text are not centered in the list-item.