Bug 398619

Summary:	Wrong subcategory selected in the sidebar after clearing search bar
Product:	[Applications] systemsettings	Reporter:	Mayeul C. <oss+kde+bugzilla>
Component:	sidebarview	Assignee:	Marco Martin <notmart>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, matejm98mthw, nate
Priority:	NOR	Keywords:	junior-jobs, usability
Version:	5.13.90
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/systemsettings/f82cca0cb07fb34e185ef8fe8d4503442c8f0308	Version Fixed In:	5.18.0
Sentry Crash Report:

Description Mayeul C. 2018-09-14 13:03:35 UTC

* Open the systemsettings, make sure the window is large enough to display the subcategory sidebar
* search an item that appears in a subcategory that is not the first one, like "cookies"
* select the category so that the kcm is displayed
* clear the search bar
* the wrong subcategory is selected (it is always the first one, "Proxy" in my case)

This makes it harder to discover the subcategory specific settings are in.

Comment 1 Matej Mrenica 2018-09-21 11:19:13 UTC

Happens exactly like described.

Comment 2 Marco Martin 2019-12-20 13:33:25 UTC

Git commit f82cca0cb07fb34e185ef8fe8d4503442c8f0308 by Marco Martin.
Committed on 20/12/2019 at 13:33.
Pushed by mart into branch 'master'.

Display sub categories when searching

Summary:
when searching, show categories *and* subcategories indented
under categories, making it way less confusing

when the user clicks at a search result the proper
category and subcategory will open

Also when clicking on most used, the proper
category/subcategory will get open on the
sidebar
Related: bug 400303
FIXED-IN: 5.18.0

Test Plan:
{F7819885}
Also old views icons and tree still work as usual

Reviewers: #plasma, #vdg, davidedmundson

Reviewed By: #plasma, #vdg, davidedmundson

Subscribers: ngraham, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26021

M  +1    -0    CMakeLists.txt
M  +35   -7    core/MenuModel.cpp
M  +20   -10   core/MenuModel.h
M  +6    -0    core/MenuProxyModel.cpp
M  +1    -0    sidebar/CMakeLists.txt
M  +173  -121  sidebar/SidebarMode.cpp
M  +35   -14   sidebar/SidebarMode.h
M  +12   -2    sidebar/ToolTips/tooltipmanager.cpp
M  +4    -1    sidebar/ToolTips/tooltipmanager.h
M  +50   -13   sidebar/package/contents/ui/CategoriesPage.qml
M  +1    -1    sidebar/package/contents/ui/IntroIcon.qml
M  +28   -9    sidebar/package/contents/ui/SubCategoryPage.qml
M  +2    -0    sidebar/package/contents/ui/main.qml

https://commits.kde.org/systemsettings/f82cca0cb07fb34e185ef8fe8d4503442c8f0308