Bug 398388

Summary:	No failure in Scheduler when Focus module fails to find a star
Product:	[Applications] kstars	Reporter:	TallFurryMan <eric.dejouhanet>
Component:	general	Assignee:	Jasem Mutlaq <mutlaqja>
Status:	RESOLVED WORKSFORME
Severity:	normal
Priority:	NOR
Version First Reported In:	2.9.8
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description TallFurryMan 2018-09-08 06:36:17 UTC

When Focus module fails to find a star, when clouds are passing by for instance, it waits for input with "Failed to automatically select a star. Please select a star manually.", and emits a signal notifying it is waiting.

Scheduler is not listening to that event, and hangs waiting indefinitely.

Scheduler should handle that situation, or Focus should make this situation a failure situation. Focus could for instance consider that no star found on frame will doom the focus procedure.

It is to be noted that when the optical train is too defocused, Focus is unable to recover and find any star. But this is another talk.

Comment 1 TallFurryMan 2018-09-08 07:34:57 UTC

Jasem, this is one of the issues that impact the d-bus rework you are currently doing. I'm worried that fixing those issues will create conflicts in your branch, but I'm also worried that such issues would better be fixed *before* your rework is complete, in order to avoid regressions. Opinion?

Comment 2 Jasem Mutlaq 2018-09-08 08:22:49 UTC

I think the scheduler should never trust any module blindly. So anything could possibly timeout in the scheduler and it jumps to action.

Comment 3 TallFurryMan 2018-09-08 08:35:08 UTC

Two things I need to fix before introducing additional timers in the Scheduler: minimal workaround for the capture storage cache count (fits analysis later on) and removal of the lock-up related to the manual scheduled auto-focus. For timers, I need to go in multiple steps, as it is related to imaging duration estimation.

Comment 4 TallFurryMan 2018-09-08 19:41:26 UTC

For this particular issue, there *is* a timeout in the Focus module, set to 45 seconds. But it is used to allow the user to pick a star, as the message suggests. I'll add a branch considering inAutoFocus, and capturing again instead of waiting for the user. Let's consider no stars mean clouds when auto-focusing.

Comment 5 Jasem Mutlaq 2022-10-10 06:23:08 UTC

Please check against KStars 3.6.1 and report back.

Comment 6 Bug Janitor Service 2022-10-25 05:00:25 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 7 Bug Janitor Service 2022-11-09 05:11:48 UTC

This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!