| Summary: | Monochrome icons vanish when selected | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Fabian Vogt <fabian> |
| Component: | view-engine: icons mode | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, nate |
| Priority: | NOR | Keywords: | usability |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/b734386cbc8436a239d20df31253a870c4e6c936 | Version Fixed In: | 18.08.2 |
|
Description
Fabian Vogt
2018-08-29 11:54:10 UTC
duplicate of bug 393075 ? (In reply to Dr. Chapatin from comment #1) > duplicate of bug 393075 ? Yes, but this one is more accurate so I'll mark that one as a dup of this. *** Bug 393075 has been marked as a duplicate of this bug. *** Git commit b734386cbc8436a239d20df31253a870c4e6c936 by Kai Uwe Broulik. Committed on 04/09/2018 at 07:01. Pushed by broulik into branch 'Applications/18.08'. Don't use QIcon::Selected state for selected icon This causes selected monochrome Breeze icons to turn white as this state is meant for when the icon is actually painted ontop of e.g. a blue highlighted area in a menu Since the advanced icon configuration (where you could choose a custom hint color and other effects) has been removed in Plasma 5.13 and more importantly the fact that Dolphin always tints the icon in the highlight color disregarding any custom icon effects settings this is an acceptable change. CHANGELOG: Fixed monochrome icons turning invisible when selected FIXED-IN: 18.08.2 Differential Revision: https://phabricator.kde.org/D15255 M +1 -1 src/kitemviews/kstandarditemlistwidget.cpp https://commits.kde.org/dolphin/b734386cbc8436a239d20df31253a870c4e6c936 |