Summary: | "Update all" button should be disabled while Discover checks for updates | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Patrick Silva <bugseforuns> |
Component: | Updates (interactive) | Assignee: | Aleix Pol <aleixpol> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate |
Priority: | NOR | Keywords: | junior-jobs, usability |
Version: | 5.13.4 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/discover/2bd91b93357318c4f7dd96b2f6e7a07dd74494c8 | Version Fixed In: | |
Attachments: | screenshot |
Yep. It *looks* like it just needs "&& !ResourcesModel.isFetching" appended to the condition governing its enabled: property, but I tried that and it didn't work... I tried and it worked for me. I'll submit the fix and then make sure it works for you too. Git commit 2bd91b93357318c4f7dd96b2f6e7a07dd74494c8 by Aleix Pol. Committed on 29/08/2018 at 16:26. Pushed by apol into branch 'master'. Disable the update button when any backend is busy Makes for a more reliable update experience. M +1 -1 discover/qml/UpdatesPage.qml https://commits.kde.org/discover/2bd91b93357318c4f7dd96b2f6e7a07dd74494c8 Go figure, now it works for me. |
Created attachment 114639 [details] screenshot Open Discover, click "Update" in the side bar, click "Check for updates" button. See my screenshot: "Check for updates" button is disabled but "Update all" remains enabled while Discover checks for updates. Reproducible on both Arch Linux (Discover 5.13.4) and neon dev unstable.