Summary: | Can't delete default Activity ? | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | isalliswell <rahul.vit2014> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, nate |
Priority: | NOR | ||
Version: | 5.13.3 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-desktop/ae8483efa40f4d47b3143405f0757a7edc126984 | Version Fixed In: | 5.12.8 |
Description
isalliswell
2018-08-26 13:16:36 UTC
Git commit eafb35076fa3e88951712a7f5bed2a33ccb7b4e0 by Nate Graham. Committed on 06/01/2019 at 06:55. Pushed by ngraham into branch 'Plasma/5.12'. [Activities KCM] Disable delete button when there's only one activity FIXED-IN; 5.12.8 M +3 -0 kcms/activities/qml/activitiesTab/ActivitiesView.qml https://commits.kde.org/plasma-desktop/eafb35076fa3e88951712a7f5bed2a33ccb7b4e0 Hi Nate, It seems like it is not merged in 5.14.5 even though it is mentioned in the 5.14.5 change log.Can you confirm? Weird. Are the buttons now vertically centered within their list items? Or is that missing too? Sorry, not sure which buttons are you talking about.Please see the below screenshot: https://i.imgur.com/NVF9HTJ.png As far as I can tell, the commit made it into the tag, so it should be present in the 5.14.5 release. Can you restart the computer and look again? Already restarted,no gain.Can you specify the file path to check the code changes? Find the path with find /usr | grep -i "ActivitiesView.qml" In that file, search for "Disable the button when there's only one activity" Well the code is there. https://i.imgur.com/1hQVzhq.png What might be the issue then,packaging in Neon? Weird! It does feel like a packaging issue, yeah. It can't be a packaging issue if the code is there on his machine. activitiesList is not defined Git commit ae8483efa40f4d47b3143405f0757a7edc126984 by David Edmundson. Committed on 10/01/2019 at 16:29. Pushed by davidedmundson into branch 'Plasma/5.12'. [Activities KCM] Fix patch to not delete default activity Summary: Patch referenced an id which didn't exist Test Plan: Had one activity, was disabled Had two, both were enabled Reviewers: #plasma, ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D18159 M +1 -0 kcms/activities/qml/activitiesTab/ActivitiesView.qml https://commits.kde.org/plasma-desktop/ae8483efa40f4d47b3143405f0757a7edc126984 |