Summary: | Some icons look fuzzy when I set 1.2 as display scaling factor | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Patrick Silva <bugseforuns> |
Component: | general | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate, sitter |
Priority: | NOR | ||
Version: | Master | ||
Target Milestone: | Not decided | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kiconthemes/89344923c00b7bc502f5c24be50027b457d82177 | Version Fixed In: | 5.57 |
Attachments: | screenshot |
Can reproduce. If you look closely, the circular icons in the sidebar have the same glitches. bug persists in plasma 5.15 beta. Operating System: Arch Linux KDE Plasma Version: 5.14.90 KDE Frameworks Version: 5.54.0 Qt Version: 5.12.0 problem is if it scales a non integer number of pixels, by definition things cannot be pixel perfect. in the end the choice is between having a sharp but glitchy image or a bit blurry. Given those options, blurry is much better than glitchy IMO. Turns out it's a double scaling in kiconloader, after all. (not that after the patch the icons are still not perfect because they can't, but immensely better) https://phabricator.kde.org/D19686 Git commit 89344923c00b7bc502f5c24be50027b457d82177 by Kai Uwe Broulik. Committed on 13/03/2019 at 11:20. Pushed by broulik into branch 'master'. Fix padding icon that doesn't exactly match the requested size The size we get already takes into account scaling, so we end up creating a pixmap whose size was scaled twice and then had the view scale it down again. Reviewed-By: Marco Martin Related: bug 396990 M +1 -1 src/kiconengine.cpp https://commits.kde.org/kiconthemes/89344923c00b7bc502f5c24be50027b457d82177 *** Bug 399335 has been marked as a duplicate of this bug. *** |
Created attachment 114274 [details] screenshot See the screenshot taken on Arch Linux, plasma 5.13.3. User manager and power saving icons look fuzzy.