| Summary: | ActionToolbar not working as intended in InlineMessage | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Fabian <fabian> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hein, nate |
| Priority: | NOR | ||
| Version First Reported In: | Master | ||
| Target Milestone: | Not decided | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kirigami/555d6a5cfb792ceb43eac05276e5b78256549112 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Code to reproduce the problem | ||
(In reply to Fabian from comment #0) > Created attachment 114221 [details] > Code to reproduce the problem > > If you add to many actions to an InlineMessage, the ActionToolbar is > overflowing the message widgets instead of collapsing the actions into an > overflow menu. looking there is indeed an issue.. tough, also the test code contains an error which makes it behave way worse when it should (also, pay attention about it in your other examples for the hig): if an item is in a layout (RowLayout, ColumnLayout, GridLayout) it should never, ever define its own width or height: it will ensure things are resizing very glitchy. at most it can have implicitWidth/height, or in the layout attached, Layout.minimumWidth preferred/maximum hints Git commit 555d6a5cfb792ceb43eac05276e5b78256549112 by Marco Martin. Committed on 02/08/2018 at 11:36. Pushed by mart into branch 'master'. better management of the size M +3 -0 src/controls/ActionToolBar.qml M +13 -13 src/controls/InlineMessage.qml https://commits.kde.org/kirigami/555d6a5cfb792ceb43eac05276e5b78256549112 |
Created attachment 114221 [details] Code to reproduce the problem If you add to many actions to an InlineMessage, the ActionToolbar is overflowing the message widgets instead of collapsing the actions into an overflow menu.