| Summary: | Freecell: Can move from foundation with double click | ||
|---|---|---|---|
| Product: | [Applications] kpat | Reporter: | xanclic |
| Component: | general | Assignee: | Stephan Kulow <coolo> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | aacid, coates, kde-games-bugs, shlomif |
| Priority: | NOR | ||
| Version: | 3.6 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kpat/49ef224f1c8e15a3583820aa2a2826a5e64de599 | Version Fixed In: | |
| Attachments: | Potential fix | ||
|
Description
xanclic
2018-07-26 14:56:50 UTC
@xancli(In reply to xanclic from comment #0) > As bug 36582 explains, recovering a card from the foundation should not be > possible, and indeed it is not possible by dragging. But it is possible to > move a card from the foundation to one of the cells by double clicking or > right clicking, which it probably should not be. Thanks for the report! I'll try to investigate. Created attachment 114153 [details]
Potential fix
I no longer have a kde-games development enviroment set up, so I can't actually test that this compiles and works, but I believe the fix should be as simple as this.
(In reply to Parker Coates from comment #2) > Created attachment 114153 [details] > Potential fix > > I no longer have a kde-games development enviroment set up, so I can't > actually test that this compiles and works, but I believe the fix should be > as simple as this. I tested this patch and it seems to fix the problem. Thanks! Also see https://github.com/shlomif/kpat/tree/fixes . Why are you now developing in a for instead of upstream? s/for/fork (In reply to Albert Astals Cid from comment #4) > Why are you now developing in a for instead of upstream? I don't know if I still have a git push bit to the kde.org repositories. Yes you do. You can check in https://websvn.kde.org/trunk/kde-common/accounts?view=markup (In reply to Albert Astals Cid from comment #7) > Yes you do. > > You can check in https://websvn.kde.org/trunk/kde-common/accounts?view=markup I see - thanks! Git commit 49ef224f1c8e15a3583820aa2a2826a5e64de599 by Albert Astals Cid, on behalf of Parker Coates. Committed on 05/08/2018 at 16:24. Pushed by aacid into branch 'Applications/18.08'. Freecell: Don't allow moving out of foundation M +2 -2 freecell.cpp https://commits.kde.org/kpat/49ef224f1c8e15a3583820aa2a2826a5e64de599 |