Bug 396521

Summary: Page header bars are suddenly too short
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Nate Graham <nate>
Component: generalAssignee: Marco Martin <notmart>
Status: VERIFIED FIXED    
Severity: normal    
Priority: VHI    
Version: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Header bar is now too short

Description Nate Graham 2018-07-15 02:07:39 UTC
Created attachment 113936 [details]
Header bar is now too short

[git master, KDE Neon dev unstable]

A recent change seems to have regressed the height of page header bars. As a result, text and buttons escape from the bounds.

Kirigami gallery is unaffected, so I filed the bug here. :)
Comment 1 Aleix Pol 2018-07-16 13:59:45 UTC
Discover does nothing specific on the headers on master.
Assigning to Kirigami.

I can reproduce as well.
Comment 2 Marco Martin 2018-07-16 14:19:41 UTC
Git commit 2e023a079f5626e47d92b19baed23011741e0fd8 by Marco Martin.
Committed on 16/07/2018 at 14:19.
Pushed by mart into branch 'master'.

fix toolbar size

M  +1    -1    src/controls/private/PageRowGlobalToolBarStyleGroup.qml

https://commits.kde.org/kirigami/2e023a079f5626e47d92b19baed23011741e0fd8
Comment 3 Nate Graham 2018-07-20 03:00:55 UTC
Verified, thanks!