| Summary: | KMAIl 5.8.1: Reply to HTML-mail in text mode includes content from last mail | ||
|---|---|---|---|
| Product: | [Applications] kmail2 | Reporter: | Axel Braun <axel.braun> |
| Component: | commands and actions | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ach, david.narvaez, kde, montel, peter, rigo, robert, wbauer1 |
| Priority: | NOR | ||
| Version: | 5.8.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Axel Braun
2018-05-28 08:53:02 UTC
Still an issue in 5.13.1 Not restricted to HTML-mails. A 'reply' just uses the content of the clipboard, from the last mail.... Git commit 22482e3299e3f6a7e5f4e7f995183054044500ba by Laurent Montel. Committed on 22/01/2020 at 06:12. Pushed by mlaurent into branch 'release/19.12'. Disable reply with quote text as this bug is back in qt5.14.x M +2 -0 messagecomposer/src/helper/messagefactoryreplyjob.cpp https://commits.kde.org/messagelib/22482e3299e3f6a7e5f4e7f995183054044500ba it's a qtwebengine bug I reported it: https://bugreports.qt.io/browse/QTBUG-81574 I created a patch for this bug. Now we need to wait that qt applies it. (In reply to Laurent Montel from comment #4) > I created a patch for this bug. Thank you! confirmed from here. Marking text and only having that text in the reply was handy and does not work anymore. kontact 13.2 in opensuse tumbleweed 20200229 (In reply to Rigo Wenning from comment #6) > confirmed from here. Marking text and only having that text in the reply was > handy and does not work anymore. kontact 13.2 in opensuse tumbleweed 20200229 normal there is a bug in qtwebengine < 5.14.2 when we don't clear selection so we can reply with previous selection text. So I disabled it. *** Bug 418005 has been marked as a duplicate of this bug. *** (In reply to Laurent Montel from comment #7) > (In reply to Rigo Wenning from comment #6) > > confirmed from here. Marking text and only having that text in the reply was > > handy and does not work anymore. kontact 13.2 in opensuse tumbleweed 20200229 > > normal there is a bug in qtwebengine < 5.14.2 when we don't clear selection > so we can reply with previous selection text. So I disabled it. I don't understand. What did you disable? Is the previous behaviour restored? I have KDE running with openSuSE Tumbleweed. This has currently kmail version 5.13.3 which corresponds to applications version 19.12.3. In this new version, the old behaviour is restored. So if you highlight text in an email and reply, only the highlighted text will be copied into the response email. And the bad behaviour described in this bug is gone. This means IMHO, that this bug should be closed I'm running Arch Linux also with KMail 5.13.3 (19.12.3) with Qt 5.14.1. The bug i still present. But, if the bug is related to the Qt version rather than to KMail this would explain this. Either OpenSUSE uses a newer Qt version or ships with a patch. Would the problem be solved by simply compiling against Qt >= 5.14.2? Or are code changes needed? For the former case this would be up to the distribution to solve this by updating to a more recent Qt version. For the latter case something like "#if (QT_VERSION >= QT_VERSION_CHECK(5, 14, 2))" or similar would be required (and compiling against a new Qt version or course). zypper if libQt5Core5 Repository : openSUSE:Tumbleweed Name : libQt5Core5 Version : 5.14.1-1.4 Arch : x86_64 Vendor : openSUSE Perhaps they patched it. It was fixed with the latest update from 2020-03-25. In this new version there were a lot of KDEPIM fixes. (In reply to Christoph Vogtländer from comment #11) > if the bug is related to the Qt version rather > than to KMail this would explain this. Either OpenSUSE uses a newer Qt > version or ships with a patch. Yes, openSUSE already contains a patch to fix the problem in QtWebEngine. But the commit in comment#2 disables the feature for all versions above 5.14.0, so that needs to be reverted/adjusted as well. OTOH, kdepim 5.14 (20.04) beta has the check removed again, so compiling that version would work too. *** Bug 420696 has been marked as a duplicate of this bug. *** I cannot reproduce this with 5.23.3 (23.04.3) on opensuse Tumbleweed. Can this be closed? I think so, I cant reproduce either! Ok, let's close it then. |